Explicitely use QRegularExpression instead of implicit string conversion #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two things here: - The use of the r-string, or raw string helps ensures that the `\d` is preserved. - I think that qtpy or conda-forge's PySide6 will throw an error if the regular expression isn't a Qt Regular Expression Thank you for considering small improvements to compatibility. Best, Mark xref: https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals
Contributor
Author
|
I'm not sure if this might be the cause but on conda-forge we have newer versons of pyside6 beyond 6.3 |
n-poulsen
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things here:
\dis preserved.Thank you for considering small improvements to compatibility.
Best,
Mark
xref: https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals