Fix rectangle selector #2227
Merged
Fix rectangle selector #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In release 3.7.0, matplotlib removed the
drawtypeattribute from theRectangleSelector. Therectpropsattribute was changed toprops(starting from release 3.5.0).To be compatible with this & future releases, they must also be removed from DLC.
This should not affect users on older matplotlib releases, as the default value was already
"box"(as shown here in release 3.3).The
rectprops=dict(facecolor='red', edgecolor='black', alpha=0.3, fill=True)argument was removed to be compatible with both matplotlib < 3.5 and matplotlib >= 3.7, so the default will be used (dict(facecolor='red', edgecolor='black', alpha=0.2, fill=True)). From my test there is no noticeable difference.