-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
GUI fixes #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI fixes #2126
Conversation
|
Thanks @KonradDanielewski! I agree that the Labeling GUI button should be enabled. |
|
Sure, I'll enable the button and pointing to napari in frame extraction today |
|
@jeylau So another reported issue is |
|
Awesome, thanks @KonradDanielewski! Does the Timer issue prevent the tracklet GUI from running though? |
|
The tracklet GUI is running and the player even starts and stops albeit with some delay, but when you try to skip forward or backward with |
|
I just noticed that the way I implemented the Location directory change is easily broken when the path isn't pasted first (every input into the Location textbox updates from all the textboxes). I'll see if I can fix this but if not it should be discarded from the pull request. |
|
Partially adresses #2161 - still haven't found out why the data from refinement isn't extracted and saved |
|
About the The |
|
I removed the textbox based location change since it wasn't working properly |
|
@KonradDanielewski, I'm looking at #2152 separately. Is your PR ready otherwise? |
|
The rest works as intended - though one issue is not resolved completely - the refinement not extracting data and creating |
|
OK, honest mistake. It doesn't export data cause there is no export in the |
|
Fixed the refined tracklets data export and mutliindex creation. Also added handling for two pandas deprecation warnings |
Because analysis was forwarded to a separate thread the dependent functions were being run before the analysis was finished. Now signal from analysis finish runs functions that were checked. Also fixes small mistake with calling self.logger instead of self.root.logger and filterpredictions having videos attribute instead of video
|
Also fixed the |
|
Sweet! I fixed the tracklet refinement GUI in #2191, so should be good to merge! |
I'm currently testing the GUI and trying to fix reported issues. One is more design improvement, i.e. being able to change the working dir also via textbox, not only by clicking the
Locationtext (I think maybe it should stand out somehow - it doesn't indicate in any way that it's a button unless you hover over it)Another thing I noticed was that label removal wasn't working in the tracklet toolbox, so also fixed that. Seems to work now.
Some other reported things that I didn't know if should be changed:
Labelling GUIbutton disabled by defualt in Extract Outlier Frames tab - what if you extracted before and are going back to refining?deeplabcut.extract_frames()