Skip to content

Conversation

@jeylau
Copy link
Contributor

@jeylau jeylau commented Oct 25, 2022

When analyzing videos with corrupted frames, we sometimes ran into silent IndexErrors due to counter exceeding the dimensions of PredictedData. Indexing is now fixed, and 0s are left when frames could not be decoded (which the user is warned about in the console).

Fixes #1996.

@jeylau jeylau added the bug fix! fix for a real buggy one... label Oct 25, 2022
@jeylau jeylau requested review from AlexEMG and MMathisLab October 25, 2022 10:31
@jeylau jeylau self-assigned this Oct 25, 2022
* Fix typo

* Fix failing tests (#2021)

* Fix pandas regression

* Update requirements.txt

* Update installation.md (#2020)

* Update installation.md

* Update installTips.md

* Update installation.md

* Add benchmark API (#1777)

* Add benchmark API
 Co-authored-by: Jessy <[email protected]>

* black formatting, added ref for datasets in benchmark

* Update installation.md (#2029)

Just a typo

Co-authored-by: Jessy Lauer <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>
@MMathisLab
Copy link
Member

@AlexEMG can we merge?

@MMathisLab MMathisLab merged commit d72b7ed into master Nov 7, 2022
@jeylau jeylau deleted the corrupted_vid_analysis branch November 8, 2022 08:44
jonahpearl pushed a commit to jonahpearl/DeepLabCut that referenced this pull request Nov 27, 2022
* Fix video analysis loop

* merging in master (DeepLabCut#2034)

* Fix typo

* Fix failing tests (DeepLabCut#2021)

* Fix pandas regression

* Update requirements.txt

* Update installation.md (DeepLabCut#2020)

* Update installation.md

* Update installTips.md

* Update installation.md

* Add benchmark API (DeepLabCut#1777)

* Add benchmark API
 Co-authored-by: Jessy <[email protected]>

* black formatting, added ref for datasets in benchmark

* Update installation.md (DeepLabCut#2029)

Just a typo

Co-authored-by: Jessy Lauer <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>

Co-authored-by: Mackenzie Mathis <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix! fix for a real buggy one...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analyse videos not working on Go Pro video

3 participants