Skip to content

Conversation

@jeylau
Copy link
Contributor

@jeylau jeylau commented Oct 21, 2022

pandas 1.5.0 introduced a regression in the groupby behavior—which we fixed with #2007—but just restored the previous behavior in 1.5.1 (see https://pandas.pydata.org/docs/whatsnew/v1.5.1.html#behavior-of-groupby-with-categorical-groupers-gh48645)
We too restore the previous code and avoid installing 1.5.0.

@jeylau jeylau added Another package code issue Bug/issue that relates to a dlc dependency bug fix! fix for a real buggy one... labels Oct 21, 2022
@jeylau jeylau requested a review from MMathisLab October 21, 2022 15:37
@jeylau jeylau self-assigned this Oct 21, 2022
@MMathisLab MMathisLab merged commit d332f42 into DeepLabCut:master Oct 29, 2022
MMathisLab added a commit that referenced this pull request Nov 4, 2022
* Fix typo

* Fix failing tests (#2021)

* Fix pandas regression

* Update requirements.txt

* Update installation.md (#2020)

* Update installation.md

* Update installTips.md

* Update installation.md

* Add benchmark API (#1777)

* Add benchmark API
 Co-authored-by: Jessy <[email protected]>

* black formatting, added ref for datasets in benchmark

* Update installation.md (#2029)

Just a typo

Co-authored-by: Jessy Lauer <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>
MMathisLab added a commit that referenced this pull request Nov 4, 2022
* Fix typo

* Fix failing tests (#2021)

* Fix pandas regression

* Update requirements.txt

* Update installation.md (#2020)

* Update installation.md

* Update installTips.md

* Update installation.md

* Add benchmark API (#1777)

* Add benchmark API
 Co-authored-by: Jessy <[email protected]>

* black formatting, added ref for datasets in benchmark

* Update installation.md (#2029)

Just a typo

Co-authored-by: Jessy Lauer <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>
MMathisLab added a commit that referenced this pull request Nov 7, 2022
* Fix video analysis loop

* merging in master (#2034)

* Fix typo

* Fix failing tests (#2021)

* Fix pandas regression

* Update requirements.txt

* Update installation.md (#2020)

* Update installation.md

* Update installTips.md

* Update installation.md

* Add benchmark API (#1777)

* Add benchmark API
 Co-authored-by: Jessy <[email protected]>

* black formatting, added ref for datasets in benchmark

* Update installation.md (#2029)

Just a typo

Co-authored-by: Jessy Lauer <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>

Co-authored-by: Mackenzie Mathis <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>
jonahpearl pushed a commit to jonahpearl/DeepLabCut that referenced this pull request Nov 27, 2022
* Fix pandas regression

* Update requirements.txt
jonahpearl pushed a commit to jonahpearl/DeepLabCut that referenced this pull request Nov 27, 2022
* Fix video analysis loop

* merging in master (DeepLabCut#2034)

* Fix typo

* Fix failing tests (DeepLabCut#2021)

* Fix pandas regression

* Update requirements.txt

* Update installation.md (DeepLabCut#2020)

* Update installation.md

* Update installTips.md

* Update installation.md

* Add benchmark API (DeepLabCut#1777)

* Add benchmark API
 Co-authored-by: Jessy <[email protected]>

* black formatting, added ref for datasets in benchmark

* Update installation.md (DeepLabCut#2029)

Just a typo

Co-authored-by: Jessy Lauer <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>

Co-authored-by: Mackenzie Mathis <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: AlexEMG <[email protected]>
Co-authored-by: Ale Santuz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Another package code issue Bug/issue that relates to a dlc dependency bug fix! fix for a real buggy one...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants