Move 'window-all-closed' handler to atom-application.js

DeeDeeG · Aerijo · DeeDeeG · commit af1daa9917a4 · 2021-01-04T05:42:50.000-05:00
Co-authored-by: Benjamin Gray &lt;bengray178@gmail.com&gt;
diff --git a/src/main-process/atom-application.js b/src/main-process/atom-application.js
@@ -773,6 +773,16 @@ module.exports = class AtomApplication extends EventEmitter {
       })
     );
 
+    // Don't quit when the last window is closed on macOS. Overrides the default Electron behavior.
+    // See: https://github.com/electron/electron/blob/v11.1.1/docs/api/app.md#event-window-all-closed
+    this.disposable.add(
+      ipcHelpers.on(app, 'window-all-closed', () => {
+        if (process.platform !== 'darwin') {
+          app.quit();
+        }
+      })
+    );
+
     // Triggered by the 'open-file' event from Electron:
     // https://electronjs.org/docs/api/app#event-open-file-macos
     // For example, this is fired when a file is dragged and dropped onto the Atom application icon in the dock.
diff --git a/src/main-process/start.js b/src/main-process/start.js
@@ -104,14 +104,6 @@ module.exports = function start(resourcePath, devResourcePath, startTime) {
     })
   );
 
-  // Don't quit when the last window is closed on macOS. Overrides the default Electron behavior.
-  // See: https://github.com/electron/electron/blob/v11.1.1/docs/api/app.md#event-window-all-closed
-  app.on('window-all-closed', () => {
-    if (process.platform !== 'darwin') {
-      app.quit();
-    }
-  });
-
   if (args.userDataDir != null) {
     app.setPath('userData', args.userDataDir);
   } else if (args.test || args.benchmark || args.benchmarkTest) {
