Skip to content

chore: Add an additional step to locally run ARA on Linux#236

Merged
omar-chahbouni-decathlon merged 1 commit into
version/5.0.0from
fix/222/adapt_the_documentation_to_linux_pc
Jan 15, 2020
Merged

chore: Add an additional step to locally run ARA on Linux#236
omar-chahbouni-decathlon merged 1 commit into
version/5.0.0from
fix/222/adapt_the_documentation_to_linux_pc

Conversation

@dktsni

@dktsni dktsni commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

Type of modification

  • Breaking change
  • New Feature
  • Bug Fix
  • Chore (refactor, documentation, tests... all the changes with no impact on ARA functionalities.)

Changes description

No behaviour modification. Only a documentation update to bypass the Docker internal network DNS limitation on GNU/Linux.

Close #222

Technical description

  • Adapt the main README.adoc to use the static ip 172.17.0.1 instead of docker.internal.host DNS on GNU/Linux in the docker-compose file.

PR CheckList

Please make sure your PullRequest respect all those items :

  • Your PR's title has the prefix : feat:, fix: or chore:
  • Unless your PR is related to a Hotfix (and approved by a ARA maintener), the targeted branch for it is the branch version/X.Y.Z and not master
  • You have asked a review from one of the ARA maintainer in your PR.
  • If your PR is related to an issue, add the issue's number in it.
  • All the code you added is documented.
  • All the code you added is tested and the tests are in success.
  • You already signed the Contributor License Agreement and give us the document

@omar-chahbouni-decathlon omar-chahbouni-decathlon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but why copy pasting instead of just adding a line:
3. (For Linux users only) Edit the ...

@dktsni

dktsni commented Jan 15, 2020

Copy link
Copy Markdown
Contributor Author

Approved, but why copy pasting instead of just adding a line:
3. (For Linux users only) Edit the ...

Because a parenthesis can be easily unread, but a title "I've got a Mac" and "I've got a GNU/Linux" not :) (IMHO at least)

@omar-chahbouni-decathlon
omar-chahbouni-decathlon merged commit 0280a5a into version/5.0.0 Jan 15, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the fix/222/adapt_the_documentation_to_linux_pc branch January 15, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

local installation does not work on Ubuntu (with Docker and docker compose)

2 participants