Merged
Conversation
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
DaveSkender
temporarily deployed
to
stockindicators.dev
GitHub Actions
Inactive
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates multiple project and package dependencies across the codebase. Changes include upgrading NuGet packages like Microsoft.SourceLink.GitHub (10.0.102 to 10.0.103), test framework dependencies (MSTest, Microsoft.NET.Test.Sdk), JKorf.Coinbase.Net, Microsoft.AspNetCore.OpenApi, and documentation dev dependencies. Project configurations including packages.lock.json files across test and tool projects are updated to reflect these version changes. Build task dependencies in Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/indicators/_common/Quotes/Quote.Validation.Tests.cs`:
- Line 56: The assertions in Quote.Validation.Tests use
Assert.IsGreaterThanOrEqualTo(r1[i - 1].Timestamp, r1[i].Timestamp) which
enforces descending timestamps, but the test data is ascending; change the
assertions to Assert.IsLessThanOrEqualTo(r1[i - 1].Timestamp, r1[i].Timestamp)
for the occurrences using r1[i - 1]/r1[i] (and likewise the similar assertions
at the other two places referencing r1 and Timestamp) so the previous timestamp
is asserted to be <= the current timestamp.
In `@tools/baselining/packages.lock.json`:
- Around line 176-180: Regenerate the tools/baselining packages.lock.json so the
test packages match the other lockfiles: update MSTest.TestAdapter and
MSTest.TestFramework from 4.0.2 to 4.1.0 and Microsoft.NET.Test.Sdk from 18.0.1
to 18.3.0, then run the lockfile generation command you use
(restore/nuget/dotnet restore with lockfile enabled) to produce an updated
lockfile that pins FluentAssertions, MSTest.TestAdapter, MSTest.TestFramework,
Microsoft.NET.Test.Sdk, and Skender.Stock.Indicators consistently with the rest
of the PR.
In `@tools/Directory.Packages.props`:
- Line 21: The PackageVersion entry for JKorf.Coinbase.Net was bumped to 3.7.0
which breaks the controlled test environment used to reproduce thread-safety
issue `#1925`; revert the PackageVersion Include="JKorf.Coinbase.Net" Version
attribute back to "2.11.3" in the existing PackageVersion element and only
change it again after explicit confirmation that thread-safety validation for
issue `#1925` is complete (or add a comment near the PackageVersion element
documenting the required validation gate).
In `@tools/simulate/packages.lock.json`:
- Around line 7-13: Update tools/simulate/README.md to reflect the dependency
version bump of JKorf.Coinbase.Net from v2.11.3 to v3.7.0: locate the README
occurrence that documents "JKorf.Coinbase.Net v2.11.3" (around the thread-safety
reproduction/validation paragraph) and change the version string to "v3.7.0";
also adjust the surrounding sentence to indicate this aligns with the completed
validation of the thread-safety fix so the README matches the versions in
Directory.Packages.props and packages.lock.json.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamland included by**
📒 Files selected for processing (14)
Stock.Indicators.slndocs/package.jsonsrc/Directory.Packages.propssrc/packages.lock.jsontests/Directory.Packages.propstests/indicators/_common/Quotes/Quote.Validation.Tests.cstests/indicators/packages.lock.jsontests/integration/packages.lock.jsontests/public-api/packages.lock.jsontools/Directory.Packages.propstools/application/packages.lock.jsontools/baselining/packages.lock.jsontools/simulate/packages.lock.jsontools/sse-server/packages.lock.json
DaveSkender
temporarily deployed
to
stockindicators.dev
GitHub Actions
Inactive
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
DaveSkender
temporarily deployed
to
stockindicators.dev
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.