feat: Migrate AI configuration to Agent Skills standard#1818
feat: Migrate AI configuration to Agent Skills standard#1818DaveSkender merged 6 commits intorefactor-agent-guardrailsfrom
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThis PR restructures the repository's AI agent guidance system, migrating from scoped instruction files and agent definitions to a skills-based architecture. Approximately 17 documentation files are removed from Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: DaveSkender <[email protected]>
Co-authored-by: DaveSkender <[email protected]>
|
@copilot Try again. You got stuck due to an issue with context size. |
The implementation is complete. All 4 phases have been successfully executed:
Latest commit: 4af62a4 |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/skills/indicator-stream/references/provider-selection.md (1)
7-17: Wrap decision tree in fenced code block for consistency.The ASCII art decision tree (lines 7-17) currently lacks a fenced code block wrapper. Per markdown guidelines, text-based diagrams should be wrapped in
```textblocks for consistency with other code examples and to ensure proper rendering across platforms.🔎 Proposed fix
## Provider decision tree - ```text + ``` Does indicator produce chainable output (single Value)? ├─ Yes → Does it need OHLCV data? │ ├─ Yes → Does it need TWO synchronized series? │ │ ├─ Yes → PairsProvider<IReusable, TResult> │ │ └─ No → ChainProvider<IQuote, TResult> │ └─ No → ChainProvider<IReusable, TResult> └─ No → Does output transform quote to quote? ├─ Yes → QuoteProvider<IQuote, TResult> └─ No → StreamHub<TIn, TResult> (ISeries output)</details> </blockquote></details> <details> <summary>.github/skills/indicator-series/references/decision-tree.md (1)</summary><blockquote> `1-138`: **Catalog skill document is comprehensive and actionable.** The CatalogListingBuilder pattern, method naming, and anti-patterns are well-explained. The critical rule on line 71 (`.WithMethodName()` placement) and line 84–85 (`isReusable` constraints) are highlighted appropriately and align with learnings. One readability suggestion: The code block at lines 18–36 demonstrates indicator construction alongside catalog patterns. While not incorrect, clarifying that lines 20–36 show *how* an indicator uses the catalog (not the catalog file itself) would prevent potential confusion about which code belongs where. </blockquote></details> <details> <summary>AGENTS.md (1)</summary><blockquote> `132-181`: **Skills framework sections are well-organized; consider clarifying structure for usage examples.** The new sections introducing Agent Skills (lines 132–153 "Skills for indicator development" and 154–167 "Skills for focused assistance") successfully replace references to old instruction files with the new skills-based framework. Content is clear and aligns with the PR objectives. The skill descriptions are actionable and include appropriate use cases. Minor observation: Lines 168–181 provide usage examples but flow directly from the skills table without an explicit section header. Adding a header like "## Usage examples" would improve clarity and help readers distinguish between the reference table (lines 154–167) and practical examples (lines 168–181). </blockquote></details> <details> <summary>.github/skills/performance-testing/references/benchmark-patterns.md (1)</summary><blockquote> `137-143`: **Minor: Consider documenting BenchmarkConfig.cs as single source of configuration.** The learnings indicate that `BenchmarkConfig.cs` should serve as the "single source of benchmark configuration" with exporters (GitHub markdown and JSON), columns (Mean, Error, StdDev), and logger settings. While your memory profiling section is solid, briefly mentioning this configuration file would help developers understand the centralized setup approach. </blockquote></details> </blockquote></details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Co-authored-by: DaveSkender <[email protected]>
Fixed multiple factual accuracy issues in commit a483397:
Added deferred refactoring tasks to plan as requested. |
Co-authored-by: DaveSkender <[email protected]>
DaveSkender
left a comment
There was a problem hiding this comment.
- See my comments below, implement those.
- As a TESTING SPECIALIST, use as much time as you can to thoroughly review your work here and improve it. Use MCP servers for external sources of best practices for guidance and to check your work. Examine each of these new guidance topic meticulously with a "fact check" mentality.
- Once you are done with the above, review it again and ensure all markdown linting has been addressed and all markdown instructions are being followed.
IMPORTANT NOTE: ALL FILES CHANGED AND IN SCOPE ARE MARKDOWN DOCUMENTATION FILES ONLY. To make yourself more efficient do not spend time repetitively building and testing the source code or running test suites. You will only need to do markdown linting commands here for testing aspects of the syntax and formatting. Don't waste your time!
There was a problem hiding this comment.
Remove all aspects of the "pairs" (e.g. like PairsProvider) based BufferList and StreamHub guidance completely. We'll be deferring implementation of those and will be removing the code aspect of those separate.
There was a problem hiding this comment.
Removed all pairs-related guidance (PairsProvider, IIncrementFromPairs) from BufferList and StreamHub skill files in commit 2472f65.
Co-authored-by: DaveSkender <[email protected]>
Completed fact-check review of all skill files:
Commit: 2472f65 |
|
Happy New Year! I admire your dedication. |
Changes in this commit
Removed pairs guidance from:
indicator-buffer/SKILL.md- Removed IIncrementFromPairs from interface table, testing requirements, and referencesindicator-buffer/references/interface-selection.md- Removed IIncrementFromPairs section and decision tree branchindicator-stream/SKILL.md- Removed PairsProvider from provider table, observer interfaces, and referencesindicator-stream/references/provider-selection.md- Removed PairsProvider section and test interface mappingFact-check corrections:
indicator-series/SKILL.md- Fixed test category (removed non-existent "StaticSeries" category)indicator-catalog/SKILL.md- Fixed catalog file path toCatalog.Listings.csUpdated all skill file dates to December 31, 2025
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.