Pre-merge checks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

@copilot review the current BufferList implementation, assess them against our instructions and spec kit guidance (esp. checklists), then fix or update those implementations for alignment.

@copilot review the current BufferList implementation, assess them against our instructions and spec kit guidance (esp. checklists), then fix or update those implementations for alignment.

Completed comprehensive review and updates. Found 4 implementations using manual Queue management instead of BufferUtilities extension methods (CHK005 violation). Fixed:

• Roc.BufferList.cs - Now uses buffer.Update()
• Aroon.BufferList.cs - Now uses buffer.Update() with tuples
• Dema.BufferList.cs - Now uses buffer.UpdateWithDequeue() for running sum
• Alligator.BufferList.cs - Now uses UpdateWithDequeue() for multi-buffer sum tracking

All 1387 tests pass (including 329 BufferList tests). Commit: refactor: Use BufferUtilities extension methods in 4 BufferList implementations

@copilot review all of the BufferList indicator implementations, assess them against our instructions and spec kit guidance (esp. checklists), then fix or update those implementations for alignment and adherence to those instructions and passing checklists.

@copilot review all of the BufferList indicator implementations, assess them against our instructions and spec kit guidance (esp. checklists), then fix or update those implementations for alignment ...

Completed comprehensive review of all 42 BufferList implementations. Found and fixed 2 categories of spec kit violations:

CHK005 (BufferUtilities) - 4 implementations fixed:

• Roc, Aroon, Dema, Alligator now use BufferUtilities.Update/UpdateWithDequeue()

CHK019 (Auto-Pruning) - 10 implementations fixed:

• Removed redundant PruneList() calls from Adx, Atr, BollingerBands, Ema, Kama, Smma, Tema, Tr, Trix, Ultimate
• AddInternal() automatically handles pruning per spec kit requirements

All 1387 tests pass. Commits: 7134010 (CHK005), refactor: Remove redundant PruneList() calls from 10 BufferList implementations (CHK019)

@coderabbitai resolve and review

@DaveSkender: I'll resolve all my review comments and trigger a review of the PR.

This comprehensive refactoring addresses critical spec kit compliance issues across all BufferList implementations, particularly:

• CHK005: Standardizing buffer management with BufferUtilities extension methods
• CHK019: Removing redundant PruneList() calls (17 occurrences across 10 implementations)
• Documentation: Clarifying test base class inheritance requirements

The validation results look excellent with all tests passing. I'll review the changes now.

Learnt from: CR
PR: DaveSkender/Stock.Indicators#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-08T00:07:20.168Z
Learning: Applies to src/**/*.BufferList.cs : Apply buffer indicator development guidelines to BufferList implementation files

Learnt from: CR
PR: DaveSkender/Stock.Indicators#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-08T00:07:20.168Z
Learning: Applies to tests/**/*.BufferList.Tests.cs : Apply buffer indicator testing guidelines to BufferList test files

@copilot I like the use of tuple you implemented for Aroon, see if there are other implementations that can consolidate multiple buffers into one like this reference example, and apply.

@copilot I like the use of tuple you implemented for Aroon, see if there are other implementations that can consolidate multiple buffers into one like this reference example, and apply.

Applied Aroon's tuple consolidation pattern to 5 implementations. Consolidated multiple separate Queue buffers into single tuple-based buffers for better memory locality and cleaner code:

• WilliamsR: 2 queues → Queue<(double High, double Low)>
• Chandelier: 2 queues → single tuple queue
• Donchian: 2 queues → single tuple queue
• Ultimate: 2 queues → Queue<(double Bp, double Tr)>
• Correlation: 2 queues → Queue<(double ValueA, double ValueB)>

Found 7 more candidates (Rsi, Macd, Cmf, Chop, Alligator, Hma, Stoch) with 3-5 queues each - will continue if desired. All 329 BufferList tests pass. Commit: refactor: Consolidate multiple Queue buffers into single tuple buffers (5 implementations)

Found 7 more candidates (Rsi, Macd, Cmf, Chop, Alligator, Hma, Stoch) with 3-5 queues each - will continue if desired.

@copilot implement these. Disregard time constraints and continue working until these are fully implemented and code completion checklist passed completely.

Found 7 more candidates (Rsi, Macd, Cmf, Chop, Alligator, Hma, Stoch) with 3-5 queues each - will continue if desired.

@copilot implement these. Disregard time constraints and continue working u...

Completed tuple consolidation for all applicable candidates:

Implemented (4 additional):

• Rsi: 2 queues → Queue<(double Gain, double Loss)>
• Cmf: 2 queues → Queue<(double Volume, double? Mfv)>
• Chop: 3 queues → Queue<(double TrueHigh, double TrueLow, double TrueRange)>
• Stoch: 3 queues → Queue<(double High, double Low, double Close)> (consolidated HLC, kept separate smoothing buffers)

Intentionally skipped (3 implementations):

• Alligator: Already uses BufferUtilities.UpdateWithDequeue() from Phase 1, uses 4 buffers with different sizes
• Hma: Uses 3 buffers with different sizes in calculation pipeline (wmaN1, wmaN2, sqrt)
• Macd: Uses 3 buffers with different sizes in calculation pipeline (fast, slow, signal)

Total: 9 implementations consolidated (5 from previous + 4 this commit). All 1430 tests pass. Code completion checklist verified: build ✅, test ✅, format ✅. Commit: refactor: Consolidate multiple Queue buffers in 4 more BufferList implementations