refactor: Add inline comments, remove info.xml#1155
Merged
DaveSkender merged 29 commits intov3from Nov 11, 2024
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
32 tasks
info.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR is primarily for code cleanup and to ensure wide consistent adoption of new conventions for inline XML commenting to replace the difficult to maintain
info.xmlfiles and to make better use of the new C#10recordclass where appropriate to maximize their utility / compatibility with streaming applications.Done when:
v3after merge of feat: Full chain streaming prototypes #1092Interfaceorvirtualwhere needed to ensure mockable.info.xmlfiles are replaced with inline XML comments using the///convention, making good use ofcrefand<inheritdoc/>from theIStockIndicatorsinterface descriptions.///comments (e.g. utility, streaming classes)recordtype where possible[Serializable]attribute, if needed