Merged
Conversation
Owner
Author
|
Note: overriding |
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
32 tasks
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (4)
tests/indicators/_common/Results/Result.Utilities.ToStringOut.Tests.cs:12
- The test method 'ToStringFixedWidth' is not implemented correctly and needs to be properly implemented.
Assert.Fail("Test not implemented, very wrong syntax.");
tests/indicators/_common/Results/Result.Utilities.ToStringOut.Tests.cs:26
- The test method 'ToStringCSV' is not implemented correctly and needs to be properly implemented.
Assert.Fail("Test not implemented, very wrong syntax.");
tests/indicators/_common/Results/Result.Utilities.ToStringOut.Tests.cs:36
- The test method 'ToStringJson' is not implemented correctly and needs to be properly implemented.
Assert.Fail("Test not implemented, very wrong syntax.");
src/_common/Generics/StringOut.cs:66
- The message should be 'ToStringOut() for JSON output ignores the number format N{decimalsToDisplay}.'
string message = $"ToStringOut() for JSON output ignores number format N{decimalsToDisplay}.";
6 tasks
* Fix the order of date as the first property in the `ToStringOut` method. * Use the `OutType` argument properly in the `ToStringOut` method. * Fix formatting issues for date in the `ToStringOut` method. * Add overloads for `.ToString(int limitQty)` and `.ToString(int startIndex, int endIndex)` methods. * Refactor the `ToStringOut` method for better performance. Add unit tests for `ToStringOut` method * Add unit tests for the new overloads `.ToString(int limitQty)` and `.ToString(int startIndex, int endIndex)`. * Add unit tests for the fixed order of date as the first property. * Add unit tests for the proper use of `OutType` argument. * Add unit tests for the fixed formatting issues for date. * Add unit tests for the refactored `ToStringOut` method performance.
* Fix the order of date as the first property in the `ToStringOut` method * Use the `OutType` argument properly in the `ToStringOut` method * Fix formatting issues for date in the `ToStringOut` method * Add overloads for `.ToString(int limitQty)` and `.ToString(int startIndex, int endIndex)` methods * Refactor the `ToStringOut` method for better performance * Add unit tests for the new overloads and fixed issues in `Result.Utilities.ToStringOut.Tests.cs`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a quirky helper utility to convert
ISeries(quotes and results lists) to a fixed width, CSV, or JSON string. Mostly, I'm thinking this is helpful anyone debugging or wanting to output something to Console for quick visual inspections or general development sharing. Default isOutType.FixedWidth, since I mostly had Console output and .NET Fiddle use in mind.To do
IResultto be parameterlessToString()? Probably not. Maybe we just use.ToStringList()or.ToStringOut()OutTypevaluesOutType.FixedWidth, it would ideally be the smallest format possible, keeping in mind that bars could be high frequency date/time values or wider..ToString(int limitQty)or.ToString(int startIndex, int endIndex)