add new function of cJSON_SetValuestring
#451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szcnick
reviewed
Mar 25, 2020
cJSON.c
Outdated
| return NULL; | ||
| } | ||
| memcpy(copy, valuestring, length); | ||
| if (!(object->type & cJSON_IsReference) && (object->valuestring != NULL)) |
Collaborator
Author
There was a problem hiding this comment.
thanks your reminder!
szcnick
reviewed
Mar 25, 2020
cJSON.c
Outdated
| { | ||
| return NULL; | ||
| } | ||
| length = strlen(valuestring) + sizeof(""); |
There was a problem hiding this comment.
If the new str length does not exceed the current value, whether to re-allocate memory
Collaborator
Author
There was a problem hiding this comment.
that's a good suggestion, In this case, we don't need to allocate memory, just re-assign the valuestring
Alanscut
force-pushed
the
20200324
branch
2 times, most recently
from
f7bd395 to
b9eb61c
Compare
Alanscut
changed the title
cJSON_SetValuestringToObjectcJSON_SetValuestring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
valuestring, we have to free the old value carefully, to make sure people could easily change it,cJSON_SetValuestringhas been added.