feat: add elastic matcher#65
Merged
Merged
Conversation
faloker
force-pushed
the
feat/elastic-matcher
branch
2 times, most recently
from
June 18, 2026 21:43
2b26cb4 to
1d8a321
Compare
faloker
force-pushed
the
feat/elastic-matcher
branch
from
June 18, 2026 21:44
1d8a321 to
950e674
Compare
Rename ElasticSecurityDetectionEngineSearchResponse to elasticSearchResponse and drop the unused Took and Total fields — it's an implementation detail with no reason to be exported.
- elastic_internal_test.go (package elastic): tests for unexported helpers alertMatchesExecution, buildElasticAlertQuery, buildAllOpenAlertsQuery - elastic_test.go (package elastic_test): tests for the public API HasExpectedAlert and Cleanup, using the generated mocks package instead of a duplicate inline fakeAlertsAPI
Contributor
|
I pushed two (mostly cosmetic) changes, otherwise it's looking great!
|
christophetd
approved these changes
Jun 19, 2026
christophetd
approved these changes
Jun 19, 2026
NathanaeldeLaChesnais
approved these changes
Jun 19, 2026
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding Elastic Security matcher, tested against Elastic Cloud
v9.2.3. Also, adding a small refactor to extractsecret.gointo a separate package to avoid duplicating a bunch of code.Motivation
Checklist