matchers(datadog) - Add WithCredentials option for explicit Datadog API credentials#48
Merged
Merged
Conversation
NathanaeldeLaChesnais
previously approved these changes
Apr 10, 2026
christophetd
previously approved these changes
Apr 10, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Minosity-VR
force-pushed
the
simon.marechal/explicit-credentials
branch
from
April 10, 2026 11:27
37bdc29 to
3866a8b
Compare
Minosity-VR
dismissed stale reviews from christophetd and NathanaeldeLaChesnais
via
April 10, 2026 11:31
3866a8b
christophetd
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhancement: allows to pass the datadog credentials directly rather than using the env vars
Motivation
When using programmatically, it can happen that we want threatest to interact with different datadog accounts. In that case, we need one pair of app/api keys per account.
goroutines share the env variables so we can't rely on that if we have mulitple parallel attacks for instance
Checklist