Fix broken CI: update Go, actions, and Dockerfile#37
Merged
Conversation
- Bump Go from 1.18/1.19 to 1.22 across CI and Dockerfile - Update actions/checkout to v4, actions/setup-go to v5 - Update staticcheck to 2024.1.1 - Update docker actions (login-action v3, build-push-action v6) - Bump Dockerfile base images to Alpine 3.20 The static analysis workflow was failing because actions/checkout@v1 depended on actions/cache@v2 which GitHub has deprecated. The Docker build was failing with newer go.mod formats incompatible with Go 1.19.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 642cd18607
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Bump goreleaser-action to v6 with version ~> v2 - Replace --rm-dist with --clean - Rename brews.repository to brews.tap - Add version: 2 to goreleaser config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkout@v4,actions/setup-go@v5,docker/login-action@v3,docker/build-push-action@v6)2024.1.1Why
actions/checkout@v1pulled inactions/cache@v2, which GitHub has fully deprecated and now auto-rejectsgo 1.23.0format in go.mod (from auto-upgrade PRs)Test plan
go build ./...passes locallymake testpasses locally