Increase reliability in case of get_orchestrion_go_version function fails#17
Merged
Conversation
nikita-tkachenko-datadog
approved these changes
Feb 28, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a custom
user-agentheader in the curl command and also now ifget_orchestrion_go_versionfails the script handles error correctly.Motivation
The curl fails sometimes with a 403 error, requests to the github api requires an
user-agent, by manually adding it fixes the issue.Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes