Adds a check for the required go version for orchestrion#16
Merged
tonyredondo merged 1 commit intoFeb 18, 2025
Merged
Conversation
…if the requirements are not met
gnufede
approved these changes
Feb 18, 2025
nikita-tkachenko-datadog
approved these changes
Feb 18, 2025
This was referenced Feb 18, 2025
Merged
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a check for the required go version for orchestrion to bail out if the requirements are not met
Motivation
Currently we always try to install orchestrion to the target Go project, but orchestrion (following the Go's support guidelines) only supports the latest stable version and the previous one at the moment of the orchestrion release. This mean that if we try to install orchestrion in an old Go project with an old Go version we currently crashes the build.
This PR tries to avoid that by checking the required go version before the orchestrion installation and bailing out safely without breaking the test job.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes