[datadog_security_monitoring_rule] Add instantaneous baseline option to NewValue#3400
Merged
dd-mergequeue[bot] merged 4 commits intomasterfrom Jan 7, 2026
Merged
Conversation
hachem-dd
force-pushed
the
mhouertani/instantaneous_baseline
branch
from
0ecaa7d to
1a34803
Compare
hachem-dd
force-pushed
the
mhouertani/instantaneous_baseline
branch
from
a1c4265 to
5db4435
Compare
paul-hf
reviewed
Jan 6, 2026
| }, | ||
| "instantaneous_baseline": { | ||
| Type: schema.TypeBool, | ||
| Required: true, |
Contributor
There was a problem hiding this comment.
Should this be required? Maybe it should be optional and default to false if not included? Otherwise users of our terraform provider will have to add instantaneous_baseline = false to all of their existing rules
Contributor
Author
There was a problem hiding this comment.
You're right. Oversight from my part 🫡 47d1bd5
rtrieu
approved these changes
Jan 6, 2026
hachem-dd
force-pushed
the
mhouertani/instantaneous_baseline
branch
from
ab199aa to
47d1bd5
Compare
hachem-dd
changed the title
hachem-dd
changed the title
paul-hf
approved these changes
Jan 7, 2026
fpighi
approved these changes
Jan 7, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira