Skip to content

[datadog_security_monitoring_rule] Replace security monitoring rules with an updated detection method#3392

Merged
dd-mergequeue[bot] merged 1 commit intomasterfrom
paul-hf/detection_method_update
Dec 29, 2025
Merged

[datadog_security_monitoring_rule] Replace security monitoring rules with an updated detection method#3392
dd-mergequeue[bot] merged 1 commit intomasterfrom
paul-hf/detection_method_update

Conversation

@paul-hf
Copy link
Copy Markdown
Contributor

@paul-hf paul-hf commented Dec 29, 2025

In the rule editor, we don't allow users to update the detection method once they've created a rule but the security monitoring terraform resource still allows it. This results in validation errors (see this example updating a threshold rule to a sequence_detection rule) when updating the rule because the API is not expecting a change in detection method. This PR adds the ForceNew flag to the detection method field which will result in the resource being deleted and created rather than updated when the detection method changes

@paul-hf paul-hf changed the title Replace security monitoring rules with an updated detection method [datadog_security_monitoring_rule] Replace security monitoring rules with an updated detection method Dec 29, 2025
@paul-hf paul-hf marked this pull request as ready for review December 29, 2025 18:47
@paul-hf paul-hf requested a review from a team as a code owner December 29, 2025 18:47
@paul-hf paul-hf requested a review from a team December 29, 2025 18:47
@paul-hf
Copy link
Copy Markdown
Contributor Author

paul-hf commented Dec 29, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Dec 29, 2025

View all feedbacks in Devflow UI.

2025-12-29 20:27:15 UTC ℹ️ Start processing command /merge


2025-12-29 20:27:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 30m (p90).


2025-12-29 20:57:45 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue Bot merged commit d5281dd into master Dec 29, 2025
21 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the paul-hf/detection_method_update branch December 29, 2025 20:57
20agbekodo added a commit that referenced this pull request Dec 31, 2025
* Replace security monitoring rules with an updated detection method (#3392)

Replace security monitoring rules with an updated detection method

Co-authored-by: paul.howardflanders <[email protected]>

* Add add_hostname, parse_xml and split_array processors

---------

Co-authored-by: Paul Howard-Flanders <[email protected]>
dd-mergequeue Bot pushed a commit that referenced this pull request Jan 15, 2026
…metrics pipelines (#3386)

[datadog_observability_pipeline] Add OpenTelemetry Source

open PR

obs-pipelines: remove `rate` config field in `sample` processors (#3384)

remove the deprecated field, in favor of alway using `percentage`, and make `percentage` required.

obs-pipelines: support for optional descriptions in SDS rule patterns (#3387)

Add add_hostname, parse_xml and split_array processors (#3395)

* Replace security monitoring rules with an updated detection method (#3392)

Replace security monitoring rules with an updated detection method

Co-authored-by: paul.howardflanders <[email protected]>

* Add add_hostname, parse_xml and split_array processors

---------

Co-authored-by: Paul Howard-Flanders <[email protected]>

Add metric pipelines (#3385)

* Add metric pipelines

add CloudPrem destination

add kafka destination

remove env var

Merge branch 'vladimir-dd/backfill' into op-ga

add too_many_buckets_option (#3405)

bump api client

[datadog_observability_pipeline] Add referencetable and datastream (#3404)

* Add support for reference_table in enrichment processor and datastream option in elastic search destination

* Update to ReferenceTable reference

* Clean up last of additional properties now that I can properly reference the types from the client

* Remove trailing new line to fix formatting issue

add include for rules + rename processors to processor_groups (#3410)

* Add include field for rules

* Rename processors to processor_groups

bump client

remove unrelated failing test

bump Go client

bump Go client

record cassettes

Merge branch 'master' into op-ga

update docs

make docs

fix typo

add OP team to codeowners

record cassettes

exclude cassettes from codeowners

Co-authored-by: 20agbekodo <[email protected]>
Co-authored-by: taylorchandleryoung <[email protected]>
Co-authored-by: clementd-dd <[email protected]>
Co-authored-by: vladimir.zhuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants