Skip to content

[datadog_deployment_gate] Add deployment gates terraform provider#3286

Merged
dd-mergequeue[bot] merged 27 commits intomasterfrom
aaron.hoffman/SDCD-1873_create-terraform-provider
Dec 19, 2025
Merged

[datadog_deployment_gate] Add deployment gates terraform provider#3286
dd-mergequeue[bot] merged 27 commits intomasterfrom
aaron.hoffman/SDCD-1873_create-terraform-provider

Conversation

@Aaron-9900
Copy link
Copy Markdown
Member

@Aaron-9900 Aaron-9900 commented Oct 15, 2025 •
edited
Loading

Adds the terraform resource for deployment gates. Includes docs and tests as well.

One point that differ from how the API behaves:

  1. Rule names must be unique within a gate. This is because at creation time, rules don't have an ID and we need something to identify rules. This is enforced by the tf client

@Aaron-9900 Aaron-9900 force-pushed the aaron.hoffman/SDCD-1873_create-terraform-provider branch 3 times, most recently from bcdb630 to 64b3985 Compare October 29, 2025 16:58
@Aaron-9900 Aaron-9900 force-pushed the aaron.hoffman/SDCD-1873_create-terraform-provider branch from e1bf8a3 to 25cdff7 Compare November 4, 2025 13:57
@Aaron-9900 Aaron-9900 force-pushed the aaron.hoffman/SDCD-1873_create-terraform-provider branch 2 times, most recently from 26989e0 to f56410c Compare December 15, 2025 09:26
@Aaron-9900 Aaron-9900 marked this pull request as ready for review December 15, 2025 10:03
@Aaron-9900 Aaron-9900 requested review from a team as code owners December 15, 2025 10:03
@Aaron-9900 Aaron-9900 changed the title Aaron.hoffman/sdcd 1873 create terraform provider SDCD-1873 | Add deployment gates terraform provider Dec 15, 2025
@Aaron-9900 Aaron-9900 changed the title SDCD-1873 | Add deployment gates terraform provider [datadog_deployment_gate] Add deployment gates terraform provider Dec 15, 2025
@Aaron-9900 Aaron-9900 marked this pull request as draft December 15, 2025 10:06
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Dec 15, 2025
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread datadog/fwprovider/resource_datadog_deployment_gate.go Outdated
@Aaron-9900 Aaron-9900 force-pushed the aaron.hoffman/SDCD-1873_create-terraform-provider branch 3 times, most recently from b1e4147 to 8cd78c6 Compare December 17, 2025 09:12
@Aaron-9900 Aaron-9900 force-pushed the aaron.hoffman/SDCD-1873_create-terraform-provider branch from 8cd78c6 to 9c4d4f6 Compare December 17, 2025 09:13
@Aaron-9900 Aaron-9900 marked this pull request as ready for review December 17, 2025 10:11
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread datadog/fwprovider/resource_datadog_deployment_gate.go
GabrielAnca
GabrielAnca reviewed Dec 17, 2025
View reviewed changes
Comment thread datadog/fwprovider/resource_datadog_deployment_gate.go Outdated
brett0000FF
brett0000FF approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small suggestion. I know the docs are auto-generated though.

Comment thread docs/resources/deployment_gate.md
Supam
Supam approved these changes Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Supam Supam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add your team to the CODEOWNERS for the newly created resources ?

@Aaron-9900
Copy link
Copy Markdown
Member Author

Aaron-9900 commented Dec 19, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Dec 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-19 10:33:27 UTC ℹ️ Start processing command /merge

2025-12-19 10:33:33 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 30m (p90).

2025-12-19 11:02:57 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue Bot merged commit c464c89 into master Dec 19, 2025
13 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the aaron.hoffman/SDCD-1873_create-terraform-provider branch December 19, 2025 11:02
paul-hf pushed a commit that referenced this pull request Dec 19, 2025
@Aaron-9900 @paul-hf
[datadog_deployment_gate] Add deployment gates terraform provider (#3286
3cc046a 
)

Add gates provider

Fixes to gate provider

Add rule resources

Update terraform provider

Undo weird changes

Add cassettes

Update go sum

Fix conflicts

Fixes

Add correct api version

Remove replace

Fixes

Fixes

Fix random issue

Fix cassettes

Merge branch 'master' into aaron.hoffman/SDCD-1873_create-terraform-provider

Fix conflicts

Add cassettes

Enforce options block

Change error message

Update descriptions and docs

Update docs/resources/deployment_gate.md

Co-authored-by: Brett Blue <[email protected]>

Make docs

Add metadata

Update cassettes again

Merge branch 'master' into aaron.hoffman/SDCD-1873_create-terraform-provider

Add codeowners

Co-authored-by: aaron.hoffman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@GabrielAnca GabrielAnca GabrielAnca approved these changes

@St0rmingBr4in St0rmingBr4in St0rmingBr4in approved these changes

@Supam Supam Supam approved these changes

@brett0000FF brett0000FF brett0000FF approved these changes

Assignees

No one assigned

Labels

changelog/documentation changelog/feature new-resource

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Aaron-9900 @GabrielAnca @St0rmingBr4in @Supam @brett0000FF