[ruby] DEBUG-5107 / DEBUG-5111: Enable probe-status path-matching edge-case tests#6920
Merged
Merged
Conversation
Removes the DEBUG-5107 and DEBUG-5111 bug markers for tests/debugger/test_debugger_probe_status.py::Test_Debugger_Line_Probe_Statuses ::test_probe_status_log_line_with_different_casing and ::test_probe_status_log_line_with_windows_path. Companion to the dd-trace-rb PR that makes Utils.path_matches_suffix? and Utils.path_can_match_spec? case-insensitive and tolerant of Windows-style backslash separators in user-supplied probe source paths.
Contributor
|
|
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: d094be3 | Docs | Datadog PR Page | Give us feedback! |
Replace the unconditional removal with prerelease-aware version gates, matching the pattern used in #6918 for DEBUG-4675 and the APMLP-1047 entries above. `<2.34.0-dev` (not `<2.34.0`) so the dev tracer is not covered by the bug marker — per semver prerelease ordering, `2.34.0-dev < 2.34.0` is true, so `<2.34.0` would skip the test on the tracer that contains the fix. Companion to DataDog/dd-trace-rb#5754 (merged), which makes `Utils.path_matches_suffix?` and `Utils.path_can_match_spec?` case-insensitive (DEBUG-5107) and tolerant of Windows-style backslash separators in user-supplied probe source paths (DEBUG-5111).
The test name `test_probe_status_log_line_with_different_casing` makes the manifest key longer than the lint's normalized-form limit. Switch to the `? key\n: value` explicit-key syntax used by other long entries in this file (e.g. lines around Test_UserLoginFailureEventV2_Tags_*). Fixes the `lint / lint` failure on commit 99d2603.
The previous form (`:` alone on its own line, then list indented below) didn't match the lint's normalized output, which expects the first list item to start on the same line as the `:`. Pattern is: `: - declaration: bug (DEBUG-5107)` on one line, followed by `component_version: '<2.34.0-dev'` indented to align with `declaration`. Fixes the lint failure on commit 4105b38.
p-datadog
changed the title
p-datadog
marked this pull request as ready for review
May 13, 2026 20:20
Strech
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version-gates the
bug (DEBUG-5107)andbug (DEBUG-5111)markers for the two probe-status path-matching edge-case tests inmanifests/ruby.ymlto'<2.34.0-dev':tests/debugger/test_debugger_probe_status.py::Test_Debugger_Line_Probe_Statuses::test_probe_status_log_line_with_different_casing— DEBUG-5107tests/debugger/test_debugger_probe_status.py::Test_Debugger_Line_Probe_Statuses::test_probe_status_log_line_with_windows_path— DEBUG-5111Companion to DataDog/dd-trace-rb#5754 (merged), which makes
Utils.path_matches_suffix?andUtils.path_can_match_spec?case-insensitive (DEBUG-5107) and tolerant of Windows-style backslash separators in user-supplied probesourceFile(DEBUG-5111).The gate uses
'<2.34.0-dev'(not'<2.34.0') so the dev tracer is not covered by the bug marker — per semver prerelease ordering,2.34.0-dev < 2.34.0is true, so'<2.34.0'would incorrectly skip the tests on the tracer that contains the fix. This matches the existing convention inruby.yml(the DEBUG-4675 entry above and the APMLP-1047 entries around lines 1170/1174/1178/1182/1186/1190 all use'<X.Y.0-dev').Validation
On commit
d094be361(this PR's tip), theDEBUGGER_PROBES_STATUSscenario ran both tests with the expected behaviour on every supported weblog:rails72— different_casingbug (DEBUG-5107)rails72— windows_pathbug (DEBUG-5111)rails80— different_casingbug (DEBUG-5107)rails80— windows_pathbug (DEBUG-5111)uds-rails— different_casingbug (DEBUG-5107)uds-rails— windows_pathbug (DEBUG-5111)Other weblogs (
rack,sinatra14/22/32/41,rails42/52/61,uds-sinatra) skip via the parent class's'*': irrelevantdeclaration — unchanged by this PR.Test plan