[Debugger] Test SymDB upload event JSON and attachment metadata#6887
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 14, 2026
Merged
Conversation
andreimatei
requested review from
KowalskiThomas,
dromanol,
manuel-alvarez-alvarez and
taegyunkim
and removed request for
a team
May 8, 2026 19:54
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 845a0bc469
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
andreimatei
force-pushed
the
andrei/symdb-event-metadata
branch
from
May 8, 2026 19:57
845a0bc to
2140beb
Compare
Contributor
|
|
andreimatei
force-pushed
the
andrei/symdb-event-metadata
branch
from
May 8, 2026 23:03
2140beb to
6fc9dbd
Compare
cbeauchesne
approved these changes
May 11, 2026
andreimatei
force-pushed
the
andrei/symdb-event-metadata
branch
from
May 12, 2026 19:49
6fc9dbd to
c6b13d4
Compare
dudikeleti
approved these changes
May 12, 2026
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 21ba712 | Docs | Datadog PR Page | Give us feedback! |
Test the upcoming extended schema of the EvP events associated to symdb uploads and the matching fields in the gzipped attachment body. The new test is initially "missing_feature" for every tracer; once the different tracers are released, the manifest entries can be moved off "missing_feature" to a version cap. The event JSON gets the following fields at the root, in camelCase to match the rest of the EvP event schema: - "ddsource" (was already required) - "service" (was already required) - "version" - "language" - "runtimeId" (was already required) - "type": "symdb" - "uploadId" - "batchNum" (1-indexed integer) - "final" (boolean) - "attachmentSize" (positive integer) The attachment body gets the matching upload metadata at the root, in snake_case to match the rest of the attachment scope schema (scope_type, source_file, ...): - "upload_id" - "batch_num" - "final" The test also cross-checks per upload that uploadId/batchNum in the event equal upload_id/batch_num in the attachment. The schema (utils/interfaces/schemas/library/symdb/v1/input-request.json) keeps the original "ddsource"/"service"/"runtimeId" as required and type-checks the new fields if present, so existing tracer versions are not regressed by the schema. The strict presence check lives in the new test_event_metadata method, which is gated per tracer/agent version via the manifests. Test harness changes: - BaseDebuggerTest gains a `symdb_upload_events` list field. - A new `_collect_symdb_upload_events()` walks every captured /symdb/v1/input request, picks the multipart parts whose Content-Disposition has name="event", and stores the parsed JSON. - collect() invokes it alongside _collect_symbols().
andreimatei
force-pushed
the
andrei/symdb-event-metadata
branch
from
May 13, 2026 15:44
c6b13d4 to
21ba712
Compare
gh-worker-dd-mergequeue-cf854d
Bot
merged commit May 14, 2026
70a6005
into
main
1407 of 1410 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
andrei/symdb-event-metadata
branch
May 14, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the upcoming extended schema of the EvP events associated to
symdb uploads and the matching fields in the gzipped attachment body.
The new test is initially "missing_feature" for every tracer; once the
different tracers are released, the manifest entries can be moved off
"missing_feature" to a version cap.
The event JSON gets the following fields at the root, in camelCase to
match the rest of the EvP event schema:
The attachment body gets the matching upload metadata at the root, in
snake_case to match the rest of the attachment scope schema
(scope_type, source_file, ...):
The test also cross-checks per upload that uploadId/batchNum in the
event equal upload_id/batch_num in the attachment.
The schema (utils/interfaces/schemas/library/symdb/v1/input-request.json)
keeps the original "ddsource"/"service"/"runtimeId" as required and
type-checks the new fields if present, so existing tracer versions are
not regressed by the schema. The strict presence check lives in the new
test_event_metadata method, which is gated per tracer/agent version via
the manifests.
Test harness changes:
symdb_upload_eventslist field._collect_symdb_upload_events()walks every captured/symdb/v1/input request, picks the multipart parts whose
Content-Disposition has name="event", and stores the parsed JSON.
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present