Skip to content

Test_Knuth_Sample_Rate failing for dd-trace-java v1.61.0#6709

Merged
mcculls merged 1 commit intomainfrom
mcculls/dd-trace-java-v1.61.0-fails-knuth-sampling
Apr 9, 2026
Merged

Test_Knuth_Sample_Rate failing for dd-trace-java v1.61.0#6709
mcculls merged 1 commit intomainfrom
mcculls/dd-trace-java-v1.61.0-fails-knuth-sampling

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Apr 9, 2026

Motivation

https://datadoghq.atlassian.net/browse/APMAPI-1880

Changes

Mark tests/parametric/test_sampling_span_tags.py::Test_Knuth_Sample_Rate::test_sampling_knuth_sample_rate_trace_sampling_rule as buggy for dd-trace-java

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

…ate::test_sampling_knuth_sample_rate_trace_sampling_rule as buggy for dd-trace-java (APMAPI-1880)
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java

@mcculls mcculls merged commit b935670 into main Apr 9, 2026
79 checks passed
@mcculls mcculls deleted the mcculls/dd-trace-java-v1.61.0-fails-knuth-sampling branch April 9, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants