fix(crashtracker): fix payload from v1 into v2 by anais-raison · Pull Request #6275 · DataDog/system-tests

anais-raison · 2026-02-11T12:24:06Z

Motivation

Having support for both v1 and v2 payload.
Libdatadog now send v2 payload : DataDog/libdatadog#1498

Changes

Fixed the crashtracking tests to handle both v1 (payload:[]) and v2 (payload:{logs:[]}) payload format so we can update to v2 without breaking the system tests.

Reviewer checklist

Anything but tests/ or manifests/ is modified ? I have the approval from R&P team

github-actions · 2026-02-11T12:24:37Z

CODEOWNERS have been resolved as:

tests/parametric/test_crashtracking.py                                  @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

datadog-datadog-prod-us1 · 2026-02-11T12:30:44Z

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

tests.parametric.test_dynamic_configuration.TestDynamicConfigSamplingRules.test_remote_sampling_rules_retention[library_env0, parametric-python]

from system_tests_suite (Datadog) (Fix with Cursor)

assert 1.0 == 0.1 ± 1.0e-07
  comparison failed
  Obtained: 1.0
  Expected: 0.1 ± 1.0e-07

self = <tests.parametric.test_dynamic_configuration.TestDynamicConfigSamplingRules object at 0x7fa7ea96da90>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7fa7b5ec7530>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7fa7b5efe8a0>

    @parametrize("library_env", [{**DEFAULT_ENVVARS}])
...

ℹ️ Info

🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 2aac755 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14ffb6f6a9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

tests/parametric/test_crashtracking.py

nccatoni

LGTM (for @DataDog/system-tests-core) but you should get a review from someone familiar with the feature

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc01770c5e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

tests/parametric/test_crashtracking.py

mhlidd

QQ, otherwise LGTM

tests/parametric/test_crashtracking.py

genesor

My main question is about keeping only one test, is mandatory ?

Having a test on v1 for a given set of tracers versions and one v2 would be easier to understand write and to understand.

Having two tests would also allow us to know when the switch from v1 → v2 happened in every tracer impacted.

EDIT: discussed live:

it's fine to keep a single test.
The assert_crash_report should be split into two func (v1 and v2) and called when needed instead of having v1 and v2 strings to improve test readability.
NIT: Another test asserting all tracer are using v2 could be added, tracer not migrated would be marked as missing_feature until they migrate

genesor

LGTM

anais-raison · 2026-02-11T17:14:25Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-02-11T17:14:28Z

View all feedbacks in Devflow UI.

2026-02-11 17:14:28 UTC ℹ️ Start processing command /merge

2026-02-11 17:14:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-02-11 19:04:57 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 9m (p90).

2026-02-11 19:12:49 UTC ℹ️ MergeQueue: This merge request was merged

This is needed to incorporate DataDog/system-tests#6275 as otherwise we get test failures https://github.com/DataDog/dd-trace-rb/actions/runs/21942765829/job/63372573702?pr=5274 ``` ============================= test session starts ============================== gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I gw0 [82] / gw1 [82] / gw2 [82] / gw3 [82] / gw4 [82] / gw5 [82] / gw6 [82] / gw7 [82] ssss................s.............x..x..............x.xxx............... [ 82%] ...F.xx... [100%] =================================== FAILURES =================================== ______________ Test_Crashtracking.test_report_crash[library_env0] ______________ [gw4] linux -- Python 3.12.12 /home/runner/work/dd-trace-rb/dd-trace-rb/venv/bin/python self = <tests.parametric.test_crashtracking.Test_Crashtracking object at 0x7f85cb97a240> test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f8596e1ac00> test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f8596e1a5a0> @pytest.mark.parametrize("library_env", [{"DD_CRASHTRACKING_ENABLED": "true"}]) def test_report_crash(self, test_agent: TestAgentAPI, test_library: APMLibrary): test_library.crash() while True: event = test_agent.wait_for_telemetry_event("logs", wait_loops=400) > if event is None or "is_crash_ping:true" not in event["payload"][0]["tags"]: E KeyError: 0 tests/parametric/test_crashtracking.py:20: KeyError ```

fix(crashtracker): fix payload from v1 into v2

7d68fee

anais-raison added 3 commits February 11, 2026 13:46

fix(crashtracker): updating test to handle both v1 and v2 payload

a55f0c8

fix(crashtracker): fix linting

bd699f4

fix(crashtracker): fix test

14ffb6f

anais-raison marked this pull request as ready for review February 11, 2026 13:58

anais-raison requested review from a team as code owners February 11, 2026 13:58

anais-raison requested review from mhlidd and removed request for a team February 11, 2026 13:58

chatgpt-codex-connector bot reviewed Feb 11, 2026

View reviewed changes

tests/parametric/test_crashtracking.py Outdated Show resolved Hide resolved

tests/parametric/test_crashtracking.py Outdated Show resolved Hide resolved

anais-raison marked this pull request as draft February 11, 2026 14:08

anais-raison and others added 2 commits February 11, 2026 15:20

fix(crashtracker): fix test

3989a8c

Merge branch 'main' into anais/fix-crashtracking

bc01770

anais-raison marked this pull request as ready for review February 11, 2026 15:57

nccatoni reviewed Feb 11, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 11, 2026

View reviewed changes

tests/parametric/test_crashtracking.py Outdated Show resolved Hide resolved

tests/parametric/test_crashtracking.py Outdated Show resolved Hide resolved

mhlidd reviewed Feb 11, 2026

View reviewed changes

tests/parametric/test_crashtracking.py Outdated Show resolved Hide resolved

genesor reviewed Feb 11, 2026

View reviewed changes

fix(crashtracker): fix test

2aac755

genesor approved these changes Feb 11, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Feb 11, 2026

gh-worker-dd-mergequeue-cf854d bot merged commit 0c9148f into main Feb 11, 2026
841 of 844 checks passed

gh-worker-dd-mergequeue-cf854d bot deleted the anais/fix-crashtracking branch February 11, 2026 19:12

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Feb 11, 2026

ivoanjo mentioned this pull request Feb 12, 2026

[PROF-13732] Upgrade libdatadog dependency to version 28.0.2 DataDog/dd-trace-rb#5274

Merged

Conversation

anais-raison commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Reviewer checklist

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

datadog-datadog-prod-us1 bot commented Feb 11, 2026 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

nccatoni left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

mhlidd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

genesor left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

genesor left a comment

Choose a reason for hiding this comment

Uh oh!

anais-raison commented Feb 11, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anais-raison commented Feb 11, 2026 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 11, 2026 •

edited by datadog-official bot

Loading

genesor left a comment •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 11, 2026 •

edited

Loading