Conversation
|
|
…d-tests-inferred-proxy-spans
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de0990e084
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| express4: *ref_5_37_0 | ||
| express5: *ref_5_37_0 | ||
| fastify: *ref_5_37_0 | ||
| express4: ">=5.37.0 <5.88.0" |
There was a problem hiding this comment.
Constraining these class declarations to >=5.37.0 <5.88.0 means Node.js express4/express5/fastify runs on >=5.88.0 now get a missing_feature declaration for all three legacy inferred-proxy classes, and Test_AWS_API_Gateway_Inferred_Span_Creation_v2 is still missing_feature in this manifest, so there is no active inferred-proxy assertion left for those versions in the integrations scenario. That silently removes regression coverage for the feature on current tracer versions.
Useful? React with 👍 / 👎.
CarlesDD
deleted the
ccapell/APPSEC-60015/nodejs-disabled-outdated-tests-inferred-proxy-spans
branch
2 participants
Motivation
New test have been written for inferred proxy span and the outdated ones must be disabled in order to merge the new feature.
Changes
Disable outdated test
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present