Skip to content

[nodejs] Enable Debugger Capture Expressesions tests for Node.js#6210

Merged
watson merged 1 commit intomainfrom
watson/DEBUG-5011/capture-expressions
Feb 16, 2026
Merged

[nodejs] Enable Debugger Capture Expressesions tests for Node.js#6210
watson merged 1 commit intomainfrom
watson/DEBUG-5011/capture-expressions

Conversation

@watson
Copy link
Copy Markdown
Contributor

@watson watson commented Feb 4, 2026 •
edited
Loading

Motivation

The Node.js tracer is adding support for Capture Expressions, and we need to also enable the system-tests for it: DataDog/dd-trace-js#7431

Changes

  • Enable tests: Removed the Node.js @missing_feature decorator from the Test_Debugger_Line_Capture_Expressions test class
  • Add manifest entries: Updated manifests/nodejs.yml to activate capture expressions tests for Node.js weblogs, starting from version 5.87.0 (next release)
  • Cleanup: Removed unused ref ref_5_82_0

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@watson Graphite App
Copy link
Copy Markdown
Contributor Author

watson commented Feb 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/debugger/test_debugger_capture_expressions.py                     @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils.py                                                 @DataDog/debugger @DataDog/system-tests-core

@watson watson mentioned this pull request Feb 4, 2026
Merged
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 bot commented Feb 4, 2026 •
edited
Loading

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

tests.test_telemetry.Test_Telemetry.test_app_started_is_first_message[flask-poc] from system_tests_suite (Datadog) (Fix with Cursor) 
AssertionError: app-started was not the first message in the first batch
assert 'generate-metrics' == 'app-started'
  - app-started
  + generate-metrics

self = <tests.test_telemetry.Test_Telemetry object at 0x7fb278eed9d0>

    @features.telemetry_app_started_event
    def test_app_started_is_first_message(self):
        """Request type app-started is the first telemetry message or the first message in the first batch"""
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ee0585a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@watson watson force-pushed the watson/DEBUG-5011/capture-expressions branch from 7a7a375 to 50c053c Compare February 13, 2026 12:59
@watson watson force-pushed the watson/DEBUG-5011/capture-expressions branch from 50c053c to ee0585a Compare February 14, 2026 11:48
@watson watson marked this pull request as ready for review February 14, 2026 12:15
@watson watson requested review from a team as code owners February 14, 2026 12:15
@watson watson merged commit de9821a into main Feb 16, 2026
827 of 829 checks passed
@watson watson deleted the watson/DEBUG-5011/capture-expressions branch February 16, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpbempel jpbempel jpbempel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@watson @jpbempel