Skip to content

[nodejs] Cap AAP service activation origin gauge metric test#5714

Merged
CarlesDD merged 1 commit into
mainfrom
ccapell/nodejs-appsec-disable-activation-origin-gauge
Nov 14, 2025
Merged

[nodejs] Cap AAP service activation origin gauge metric test#5714
CarlesDD merged 1 commit into
mainfrom
ccapell/nodejs-appsec-disable-activation-origin-gauge

Conversation

@CarlesDD

Copy link
Copy Markdown
Contributor

Motivation

The legacy implementation of AAP service activation origin reporting will be removed, as it will now be handled through configuration telemetry.

Changes

Cap tracer versions for legacy implementation tests in Node.js manifest.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js

@CarlesDD
CarlesDD marked this pull request as ready for review November 14, 2025 04:31
@CarlesDD
CarlesDD requested a review from a team as a code owner November 14, 2025 04:31
@CarlesDD CarlesDD self-assigned this Nov 14, 2025
@CarlesDD
CarlesDD enabled auto-merge (squash) November 14, 2025 04:38
@CarlesDD
CarlesDD merged commit 4772cb1 into main Nov 14, 2025
54 checks passed
@CarlesDD
CarlesDD deleted the ccapell/nodejs-appsec-disable-activation-origin-gauge branch November 14, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants