Skip to content

[debugger] Add test for snapshot default capture limits#5624

Merged
dd-mergequeue[bot] merged 5 commits into
mainfrom
watson/test-snapshot-defaults
Nov 4, 2025
Merged

[debugger] Add test for snapshot default capture limits#5624
dd-mergequeue[bot] merged 5 commits into
mainfrom
watson/test-snapshot-defaults

Conversation

@watson

@watson watson commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

Better test coverage.

Changes

Add comprehensive tests to the debugger product, to verify that tracers correctly apply default capture limits when no capture property is specified in the probe configuration:

  • maxReferenceDepth: 3
  • maxCollectionSize: 100
  • maxFieldCount: 20
  • maxLength: 255

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@watson Graphite App

watson commented Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/debugger/utils/probes/probe_snapshot_default_capture_limits.json  @DataDog/debugger @DataDog/system-tests-core
utils/build/docker/dotnet/weblog/Models/Debugger/DataGenerator.cs       @DataDog/apm-dotnet @DataDog/asm-dotnet @DataDog/system-tests-core
utils/build/docker/java/spring-boot/src/main/java/com/datadoghq/system_tests/springboot/debugger/DataGenerator.java  @DataDog/apm-java @DataDog/asm-java @DataDog/system-tests-core
utils/build/docker/nodejs/express/debugger/data_generator.js            @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/nodejs/express4-typescript/debugger/data_generator.ts  @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/nodejs/fastify/debugger/data_generator.js            @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/python/flask/debugger/data_generator.py              @DataDog/apm-python @DataDog/asm-python @DataDog/system-tests-core
utils/build/docker/ruby/shared/rails/app/models/data_generator.rb       @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
tests/debugger/test_debugger_probe_snapshot.py                          @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils.py                                                 @DataDog/debugger @DataDog/system-tests-core
utils/build/docker/dotnet/weblog/Controllers/DebuggerController.cs      @DataDog/apm-dotnet @DataDog/asm-dotnet @DataDog/system-tests-core
utils/build/docker/java/spring-boot/src/main/java/com/datadoghq/system_tests/springboot/debugger/DebuggerController.java  @DataDog/apm-java @DataDog/asm-java @DataDog/system-tests-core
utils/build/docker/nodejs/express/debugger/index.js                     @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/nodejs/express4-typescript/debugger/index.ts         @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/nodejs/fastify/debugger/index.js                     @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/python/flask/debugger_controller.py                  @DataDog/apm-python @DataDog/asm-python @DataDog/system-tests-core
utils/build/docker/ruby/rails72/config/routes.rb                        @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails80/config/routes.rb                        @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/shared/rails/app/controllers/debugger_controller.rb  @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core

@watson
watson force-pushed the watson/test-snapshot-defaults branch 9 times, most recently from 0178561 to 33edbff Compare October 30, 2025 13:04
@watson watson mentioned this pull request Oct 30, 2025
Merged
6 tasks
@watson
watson force-pushed the watson/test-snapshot-defaults branch 5 times, most recently from f353686 to 4d3e287 Compare October 31, 2025 10:26
@watson
watson marked this pull request as ready for review October 31, 2025 10:27
@watson
watson requested review from a team as code owners October 31, 2025 10:27
@watson
watson removed the request for review from a team October 31, 2025 10:27
@watson
Add test for debugger snapshot default capture limits
e4b05c6 
Add comprehensive test to verify that tracers correctly apply default
capture limits when no capture property is specified in the probe
configuration:

- `maxReferenceDepth`: 3
- `maxCollectionSize`: 100
- `maxFieldCount`: 20
- `maxLength`: 255
@watson
watson force-pushed the watson/test-snapshot-defaults branch from 4d3e287 to e4b05c6 Compare October 31, 2025 12:25
jpbempel
jpbempel approved these changes Oct 31, 2025
View reviewed changes

@jpbempel jpbempel left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Java part

And thanks for adding those tests!

p-datadog
p-datadog approved these changes Nov 3, 2025
View reviewed changes
Comment thread tests/debugger/test_debugger_probe_snapshot.py
@p-datadog p-datadog mentioned this pull request Nov 3, 2025
Merged
6 tasks
P403n1x87
P403n1x87 approved these changes Nov 3, 2025
View reviewed changes

@P403n1x87 P403n1x87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@watson

watson commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-04 13:33:38 UTC ℹ️ Start processing command /merge

2025-11-04 13:33:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-04 14:19:24 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 10m (p90).

2025-11-04 14:25:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 79258bb into main Nov 4, 2025
584 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the watson/test-snapshot-defaults branch November 4, 2025 14:25
Strech pushed a commit that referenced this pull request Nov 18, 2025
@watson @Strech
[debugger] Add test for snapshot default capture limits (#5624)
7d7583f 
Co-authored-by: thomas.watson <[email protected]>
@p-datadog p-datadog mentioned this pull request May 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-datadog p-datadog p-datadog approved these changes
@tylfin tylfin tylfin approved these changes
@jpbempel jpbempel jpbempel approved these changes
@P403n1x87 P403n1x87 P403n1x87 approved these changes
@tabgok tabgok Awaiting requested review from tabgok tabgok is a code owner automatically assigned from DataDog/apm-python
@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java
@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java
@sezen-datadog sezen-datadog Awaiting requested review from sezen-datadog sezen-datadog is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@watson @tylfin @jpbempel @P403n1x87 @p-datadog