Skip to content

Feature Flags Experiments Go#5580

Merged
eliottness merged 8 commits into
mainfrom
eliottness/ffe-go
Nov 17, 2025
Merged

Feature Flags Experiments Go#5580
eliottness merged 8 commits into
mainfrom
eliottness/ffe-go

Conversation

@eliottness

@eliottness eliottness commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Motivation

https://docs.google.com/document/d/1M4delPpJrBOP437aj8QZRMvDc8JNV260oLMuLZWTwZ0/edit?tab=t.0

Changes

Support for Feature Flagging Experiments

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions

github-actions Bot commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/golang/app/_shared/common/ffe.go                     @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/parametric/ffe.go                             @DataDog/dd-trace-go-guild @DataDog/system-tests-core
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
utils/build/docker/golang/app/chi/main.go                               @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/echo/main.go                              @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/gin/main.go                               @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/go.mod                                    @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/go.sum                                    @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/net-http-orchestrion/main.go              @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/net-http/main.go                          @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/go.work.sum                                   @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/parametric/go.mod                             @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/parametric/go.sum                             @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/parametric/main.go                            @DataDog/dd-trace-go-guild @DataDog/system-tests-core

Base automatically changed from khanayan123/add-ffe-tests to main October 22, 2025 15:51
@eliottness eliottness mentioned this pull request Oct 22, 2025
Merged
@eliottness
eliottness force-pushed the eliottness/ffe-go branch 2 times, most recently from 5cae651 to 9d9adf1 Compare November 3, 2025 10:08
@eliottness eliottness changed the title [golang] Feature Flags Experiments Feature Flags Experiments Go Nov 3, 2025
@eliottness
[golang] feature flags for go
bd29cec 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
[golang] feature flags for go
ce184e6 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
fix weblog
fb1ffd1 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
fix changed API
8945b5b 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
remove go get
fadd306 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
upgrade dd-trace-go to latest rc
6aa16b1 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
change the enablement to 2.5
6547ac0 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
upgrade to v2.4.0
f9bbda4 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
eliottness marked this pull request as ready for review November 14, 2025 16:09
@eliottness
eliottness requested review from a team as code owners November 14, 2025 16:09
darccio
darccio approved these changes Nov 14, 2025
View reviewed changes

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoromanovsky

leoromanovsky commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

@eliottness you're probably waiting on the 2.5.0-rc tag to be cut to merge this?

@eliottness
eliottness merged commit abfa588 into main Nov 17, 2025
580 checks passed
@eliottness
eliottness deleted the eliottness/ffe-go branch November 17, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @leoromanovsky @darccio