Skip to content

enable service renaming in appsec#5541

Merged
cbeauchesne merged 7 commits into
mainfrom
christophe-papazian/service_renaming_for_appsec
Oct 21, 2025
Merged

enable service renaming in appsec#5541
cbeauchesne merged 7 commits into
mainfrom
christophe-papazian/service_renaming_for_appsec

Conversation

@christophe-papazian

@christophe-papazian christophe-papazian commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Motivation

Resource renaming must be enable when appsec is.

Changes

Enable resource renaming tests in appsec_blocking
Enable the tests for python after DataDog/dd-trace-py#14926

APPSEC-59693

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/endtoend.py                                   @DataDog/system-tests-core

christophe-papazian added a commit to DataDog/dd-trace-py that referenced this pull request Oct 17, 2025
…4926)

## Description

Resource renaming must be enabled if appsec is enabled at start.

## Testing

This is tested on snapshots tests.
This will be tested on system tests.
DataDog/system-tests#5541

## Risks

This will enable resource renaming by default for aap users.

APPSEC-59693

@e-n-0 e-n-0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophe-papazian
christophe-papazian marked this pull request as ready for review October 17, 2025 14:02
@christophe-papazian
christophe-papazian requested review from a team as code owners October 17, 2025 14:02
@christophe-papazian
christophe-papazian requested review from rachelyangdog and vlad-scherbich and removed request for a team October 17, 2025 14:02
@christophe-papazian
christophe-papazian enabled auto-merge (squash) October 17, 2025 15:06
@cbeauchesne
cbeauchesne disabled auto-merge October 21, 2025 11:42
@cbeauchesne
cbeauchesne merged commit 9314c50 into main Oct 21, 2025
2025 of 2028 checks passed
@cbeauchesne
cbeauchesne deleted the christophe-papazian/service_renaming_for_appsec branch October 21, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants