Skip to content

ensure resource renaming tests are also run on appsec scenario#5529

Merged
christophe-papazian merged 1 commit into
mainfrom
christophe-papazian/resource_renaming_in_appsec
Oct 16, 2025
Merged

ensure resource renaming tests are also run on appsec scenario#5529
christophe-papazian merged 1 commit into
mainfrom
christophe-papazian/resource_renaming_in_appsec

Conversation

@christophe-papazian

@christophe-papazian christophe-papazian commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Motivation

RFC changes specify that resource renaming must be enabled if appsec is enabled at start.

Changes

Add resource renaming tests to appsec blocking scenario

APPSEC-59682

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/test_resource_renaming.py                                         @DataDog/system-tests-core

@christophe-papazian
christophe-papazian marked this pull request as ready for review October 16, 2025 10:53
@christophe-papazian
christophe-papazian requested a review from a team as a code owner October 16, 2025 10:53
@christophe-papazian
christophe-papazian enabled auto-merge (squash) October 16, 2025 11:33
@christophe-papazian
christophe-papazian merged commit 5a29727 into main Oct 16, 2025
396 checks passed
@christophe-papazian
christophe-papazian deleted the christophe-papazian/resource_renaming_in_appsec branch October 16, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants