Skip to content

Merge TELEMETRY_METRIC_GENERATION_ENABLED scenario into AGENT_SUPPORTING_SPAN_EVENTS#5315

Merged
jandro996 merged 6 commits into
mainfrom
alejandro.gonzalez/merge-scenario-TELEMETRY_METRIC_GENERATION_ENABLED
Sep 25, 2025
Merged

Merge TELEMETRY_METRIC_GENERATION_ENABLED scenario into AGENT_SUPPORTING_SPAN_EVENTS#5315
jandro996 merged 6 commits into
mainfrom
alejandro.gonzalez/merge-scenario-TELEMETRY_METRIC_GENERATION_ENABLED

Conversation

@jandro996

@jandro996 jandro996 commented Sep 22, 2025

Copy link
Copy Markdown
Member

Motivation

As the system-tests repository grows, we need to ensure efficient test matrix management by preventing duplicate scenarios and identifying opportunities to merge similar EndToEnd scenarios. Duplicate scenarios waste CI resources and increase maintenance overhead without providing additional test coverage.

Changes

remove TELEMETRY_METRIC_GENERATION_ENABLED scenario and replace annotated tests with agent_supporting_span_events

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@jandro996 jandro996 changed the title WIP Merge TELEMETRY_METRIC_GENERATION_ENABLED scenario into AGENT_SUPPORTING_SPAN_EVENTS Sep 23, 2025
@jandro996
jandro996 force-pushed the alejandro.gonzalez/merge-scenario-TELEMETRY_METRIC_GENERATION_ENABLED branch from c4805a0 to ce2a60c Compare September 23, 2025 14:31
@jandro996
jandro996 marked this pull request as ready for review September 24, 2025 10:24
@jandro996
jandro996 requested review from a team as code owners September 24, 2025 10:24
@jandro996
jandro996 requested review from cbeauchesne, cecile75, paullegranddc and robertomonteromiguel and removed request for a team September 24, 2025 10:24

@robertomonteromiguel robertomonteromiguel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need also remove the scenarios from

"TELEMETRY_METRIC_GENERATION_ENABLED": {
?

Comment thread tests/test_the_test/test_minimal_number_of_scenarios.py
Comment thread utils/_context/_scenarios/__init__.py Outdated
@jandro996
jandro996 merged commit 83da1dc into main Sep 25, 2025
2072 checks passed
@jandro996
jandro996 deleted the alejandro.gonzalez/merge-scenario-TELEMETRY_METRIC_GENERATION_ENABLED branch September 25, 2025 11:45
chagui pushed a commit that referenced this pull request Oct 1, 2025
…ING_SPAN_EVENTS (#5315)

Motivation
As the system-tests repository grows, we need to ensure efficient test matrix management by preventing duplicate scenarios and identifying opportunities to merge similar EndToEnd scenarios. Duplicate scenarios waste CI resources and increase maintenance overhead without providing additional test coverage.

Changes
remove TELEMETRY_METRIC_GENERATION_ENABLED scenario and replace annotated tests with agent_supporting_span_events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants