Skip to content

[skip ci] feat: test process discovery v2 payload#5292

Merged
raphaelgavache merged 3 commits into
mainfrom
dmehala/add-config-memfd-v2
Sep 30, 2025
Merged

[skip ci] feat: test process discovery v2 payload#5292
raphaelgavache merged 3 commits into
mainfrom
dmehala/add-config-memfd-v2

Conversation

@dmehala

@dmehala dmehala commented Sep 18, 2025 •
edited by raphaelgavache
Loading

Copy link
Copy Markdown
Contributor

[lang support]

  • test tracer metadata for go

[docker build fix]

  • docker built with /binaries/golang-load-from-go-get and a custom tracer failed, fixed the image generation

[feature evolution]

  • add the ability to test v2 and v1 tracer metadata.

v2 is for go is tested against this PR DataDog/dd-trace-go#3960

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@raphaelgavache
raphaelgavache force-pushed the dmehala/add-config-memfd-v2 branch 2 times, most recently from abd6a9c to f287a6a Compare September 30, 2025 04:02
@raphaelgavache
raphaelgavache marked this pull request as ready for review September 30, 2025 04:04
@raphaelgavache
raphaelgavache requested review from a team and mabdinur as code owners September 30, 2025 04:04
@raphaelgavache raphaelgavache mentioned this pull request Sep 30, 2025
Merged
7 tasks
@raphaelgavache
raphaelgavache force-pushed the dmehala/add-config-memfd-v2 branch from f287a6a to 192b82d Compare September 30, 2025 04:12
cbeauchesne
cbeauchesne approved these changes Sep 30, 2025
View reviewed changes

@cbeauchesne cbeauchesne left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From framework usage, all good. Could you get a review from someone familair with the teste feature ?

@raphaelgavache

raphaelgavache commented Sep 30, 2025

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-30 14:40:26 UTC ℹ️ Start processing command /merge

2025-09-30 14:40:43 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-30 17:41:11 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 12m (p90).

2025-09-30 17:59:14 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@raphaelgavache
raphaelgavache merged commit 6ac7587 into main Sep 30, 2025
1259 of 1261 checks passed
@raphaelgavache
raphaelgavache deleted the dmehala/add-config-memfd-v2 branch September 30, 2025 17:59
chagui pushed a commit that referenced this pull request Oct 1, 2025
@dmehala @raphaelgavache @chagui
[skip ci] feat: test process discovery v2 payload (#5292)
d6b2d42 
Co-authored-by: raphael.gavache <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rarguelloF rarguelloF rarguelloF approved these changes
@amarziali amarziali amarziali approved these changes
@cbeauchesne cbeauchesne cbeauchesne approved these changes
@raphaelgavache raphaelgavache raphaelgavache approved these changes
@mabdinur mabdinur Awaiting requested review from mabdinur

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dmehala @raphaelgavache @rarguelloF @amarziali @cbeauchesne