Merge APPSEC_REQUEST_BLOCKING scenario into APPSEC_BLOCKING_FULL_DENYLIST#5277
Merged
jandro996 merged 2 commits intoSep 23, 2025
Merged
Conversation
cbeauchesne
requested changes
Sep 17, 2025
Collaborator
There was a problem hiding this comment.
There are three references to APPSEC_REQUEST_BLOCKING to remove : https://github.com/search?q=org%3ADataDog%20APPSEC_REQUEST_BLOCKING&type=code
Member
Author
|
Ahh sorry! I already updated the system-tests side, but I didn’t realize some tracers have references to the scenarios in their own projects… Any idea how to orchestrate this? I guess we need to remove those references from the tracers first, and only then update the system-tests. Am I right? |
6 tasks
jandro996
force-pushed
the
alejandro.gonzalez/remove-APPSEC_REQUEST_BLOCKING-scenario
branch
from
September 22, 2025 08:15
1d702a5 to
5ba02ca
Compare
cbeauchesne
approved these changes
Sep 23, 2025
| @@ -2513,110 +2513,6 @@ | |||
| "uds-sinatra": 44 | |||
Collaborator
There was a problem hiding this comment.
For future PR, no need to change this file, it's automatically generated
jandro996
deleted the
alejandro.gonzalez/remove-APPSEC_REQUEST_BLOCKING-scenario
branch
September 23, 2025 14:20
This was referenced Sep 24, 2025
jandro996
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Sep 24, 2025
…L_DENYLIST in ST (#4910) What does this PR do? This PR just cleans up the pipeline by removing the reference to the no-longer-existing scenario. Motivation: The scenario APPSEC_REQUEST_BLOCKING has been merged into APPSEC_BLOCKING_FULL_DENYLIST in the system-tests project. This means tests that were previously run under APPSEC_REQUEST_BLOCKING will now execute using APPSEC_BLOCKING_FULL_DENYLIST (DataDog/system-tests#5277)
7 tasks
jandro996
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Sep 24, 2025
## Description The scenario APPSEC_REQUEST_BLOCKING has been merged into APPSEC_BLOCKING_FULL_DENYLIST in the system-tests project. This means tests that were previously run under APPSEC_REQUEST_BLOCKING will now execute using APPSEC_BLOCKING_FULL_DENYLIST (DataDog/system-tests#5277) This PR just cleans up the pipeline by removing the reference to the no-longer-existing scenario and updates ST version ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers -->
chagui
pushed a commit
that referenced
this pull request
Oct 1, 2025
…LIST (#5277) Motivation As the system-tests repository grows, we need to ensure efficient test matrix management by preventing duplicate scenarios and identifying opportunities to merge similar EndToEnd scenarios. Duplicate scenarios waste CI resources and increase maintenance overhead without providing additional test coverage. Changes remove APPSEC_REQUEST_BLOCKING scenario and replace annotated tests with APPSEC_BLOCKING_FULL_DENYLIST
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As the system-tests repository grows, we need to ensure efficient test matrix management by preventing duplicate scenarios and identifying opportunities to merge similar EndToEnd scenarios. Duplicate scenarios waste CI resources and increase maintenance overhead without providing additional test coverage.
Changes
remove APPSEC_REQUEST_BLOCKING scenario and replace annotated tests with APPSEC_BLOCKING_FULL_DENYLIST
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present