Skip to content

add end to end system tests for resource renaming#5267

Merged
florentinl merged 7 commits into
mainfrom
florentin.labelle/APPSEC-58892/resource-renaming
Sep 17, 2025
Merged

add end to end system tests for resource renaming#5267
florentinl merged 7 commits into
mainfrom
florentin.labelle/APPSEC-58892/resource-renaming

Conversation

@florentinl

@florentinl florentinl commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Motivation

Test the resource renaming feature in the system-tests. This feature adds:

Changes

Add test cases that checks the content of the http.endpoint tag as well as the presence of the resource renaming keys in the span stats emitted by the tracer ("Method" and "Endpoint").

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@florentinl
florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch 5 times, most recently from 44466aa to 526bdef Compare September 16, 2025 13:08
Comment thread utils/_context/_scenarios/__init__.py Outdated
@florentinl florentinl changed the title new scenario for resource renaming add end to end system tests for resource renaming Sep 16, 2025
@florentinl
florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch from a223f9c to 09ed0e4 Compare September 17, 2025 08:12
Comment thread tests/test_resource_renaming.py
@florentinl
florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch from 09ed0e4 to 0036271 Compare September 17, 2025 09:47
@florentinl
florentinl marked this pull request as ready for review September 17, 2025 11:48
@florentinl
florentinl requested review from a team as code owners September 17, 2025 11:48
@florentinl
florentinl requested review from a team as code owners September 17, 2025 11:48
@florentinl
florentinl requested review from emmettbutler, manuel-alvarez-alvarez, rachelyangdog and robertpi and removed request for a team September 17, 2025 11:48
@florentinl
florentinl marked this pull request as draft September 17, 2025 11:48
@florentinl
florentinl marked this pull request as ready for review September 17, 2025 12:38
@florentinl
florentinl merged commit 50d026d into main Sep 17, 2025
1972 checks passed
@florentinl
florentinl deleted the florentin.labelle/APPSEC-58892/resource-renaming branch September 17, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants