Skip to content

[nodejs] Enable activation metrics in Node.js#4734

Merged
uurien merged 2 commits into
mainfrom
ugaitz/enable-appsec-activation-metrics
Jun 9, 2025
Merged

[nodejs] Enable activation metrics in Node.js#4734
uurien merged 2 commits into
mainfrom
ugaitz/enable-appsec-activation-metrics

Conversation

@uurien

@uurien uurien commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Motivation

Feature implemented here (DataDog/dd-trace-js#5794)

Changes

nodejs.yml enabling the tests

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@uurien uurien changed the title Enable activation metrics in Node.js [nodejs] Enable activation metrics in Node.js Jun 6, 2025
@uurien
uurien marked this pull request as ready for review June 6, 2025 09:38
@uurien
uurien requested a review from a team as a code owner June 6, 2025 09:38
@uurien
uurien merged commit 57027b8 into main Jun 9, 2025
40 checks passed
@uurien
uurien deleted the ugaitz/enable-appsec-activation-metrics branch June 9, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants