Enable Test_Stable_Config_Default for go v2#4604
Closed
mtoffl01 wants to merge 176 commits into
Closed
Conversation
…ch's latest commit
This reverts commit d74dcf6.
7 tasks
…dy (don't know when for sure)
mtoffl01
marked this pull request as ready for review
June 2, 2025 13:55
darccio
approved these changes
Jun 4, 2025
Comment on lines
+382
to
+385
| if context.library == "php" | ||
| else "true" | ||
| if context.library == "golang" | ||
| else "false", # Profiling is enabled as "1" by default in PHP if loaded. As for Go, the profiler must be started manually, so it is enabled by default when started |
Member
There was a problem hiding this comment.
This feels cursed, but it works 🤣 I wonder how Python parses if statements so this one-liner works:
"false" if context.library != "php" else "true" if context.library == "golang" else "false"
darccio
added a commit
that referenced
this pull request
Jun 10, 2025
… installation assimilating #4604 changes
mtoffl01
marked this pull request as draft
June 12, 2025 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present