Ensure DI PII line probe tests actually run for all tracers#3823
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
watson
force-pushed
the
watson/DEBUG-2745/fix-pii-tests
branch
from
January 15, 2025 12:43
5f571cd to
2f04d32
Compare
This was referenced Jan 15, 2025
watson
commented
Jan 15, 2025
watson
force-pushed
the
watson/DEBUG-2745/fix-pii-tests
branch
6 times, most recently
from
January 18, 2025 08:55
d8bfb51 to
3169298
Compare
watson
commented
Jan 18, 2025
6 tasks
watson
force-pushed
the
watson/DEBUG-2745/fix-pii-tests
branch
from
January 18, 2025 10:06
c7a4295 to
ca0c988
Compare
Only Ruby PII line probe tests were evaluated prior to this commit, as the `@missing_feature` annotation for Ruby was incorrectly negated. This issue was hiding tests that actually failed for Node.js which this commit also fixes.
watson
force-pushed
the
watson/DEBUG-2745/fix-pii-tests
branch
2 times, most recently
from
January 19, 2025 06:18
66e9a74 to
183f7d1
Compare
watson
marked this pull request as ready for review
January 19, 2025 06:18
watson
requested review from
ValentinZakharov,
amarziali,
avara1986,
manuel-alvarez-alvarez,
sabrenner and
songy23
and removed request for
a team
January 19, 2025 06:18
Contributor
Author
|
Note that currently the Node.js tests will fail, until the depended upon PRs mentioned in the PR description has been merged and the tests re-run. However, I've tested this already so the review can start already now |
cbeauchesne
requested changes
Jan 20, 2025
Collaborator
There was a problem hiding this comment.
CI is failing on node : https://github.com/DataDog/system-tests/actions/runs/12851038726/job/35831460207?pr=3823#step:63:81
Edit : just saw your comment. you can dismiss my review and merge once the PR on node is merged and the test green 😄
cbeauchesne
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Better test coverage :)
Changes
Only Ruby PII line probe tests were evaluated prior to this PR, as the
@missing_featureannotation for Ruby was incorrectly negated. So in reality it as only testing Ruby and nothing else. That implies that Ruby was actually working, since it wasn't complaining. So this PR have completely removed that@missing_featureannotation.This issue was hiding tests that actually failed for Node.js which this PR also fixes (the majority of changes in this PR).
Depends on:
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present