Query string obfuscation tests for http client and server spans#3783
Merged
Conversation
7 tasks
mtoffl01
requested review from
a team,
khanayan123,
link04 and
mabdinur
and removed request for
a team
January 14, 2025 21:03
mtoffl01
marked this pull request as ready for review
January 14, 2025 21:04
mtoffl01
requested review from
Anilm3,
Mariovido,
PerfectSlayer and
ValentinZakharov
and removed request for
a team
January 14, 2025 21:04
robertomonteromiguel
requested changes
Jan 16, 2025
| self.r = weblog.get("/make_distant_call", params={"url": "http://weblog:7777/?ssn=123-45-6789"}) | ||
|
|
||
| @missing_feature(context.library == "nodejs", reason="Node only obfuscates queries on the server side") | ||
| @missing_feature( |
Collaborator
There was a problem hiding this comment.
why test_query_string_obfuscation_empty_client is marked as irrrelevant and test_query_string_obfuscation_configured_client is marked as missing_feature?
Contributor
Author
There was a problem hiding this comment.
should be good now
| ) | ||
|
|
||
|
|
||
| @scenarios.default |
Collaborator
There was a problem hiding this comment.
if there is not a @scenarios decorator, it's set as default. No marker needed
robertomonteromiguel
approved these changes
Jan 17, 2025
darccio
approved these changes
Jan 17, 2025
cbeauchesne
approved these changes
Jan 17, 2025
cbeauchesne
left a comment
cbeauchesne
left a comment
Collaborator
There was a problem hiding this comment.
All good, sorry for the previous review, github showed me a strange commit ...
bm1549
added a commit
that referenced
this pull request
Apr 14, 2026
PHP dd-trace-php PR #3783 changed telemetry config names from INI-derived dot notation (e.g. trace.debug) to canonical env var names (e.g. DD_TRACE_DEBUG). Update the telemetry_name_mapping for PHP accordingly and bump the manifest version to 1.19.0. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Test that
DD_TRACE_OBFUSCATION_QUERY_STRING_REGEXPapplies to both http client and http server spans.Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present