parametric: Ensure start span endpoints align with the spec#3300
Merged
Conversation
mabdinur
force-pushed
the
munir/simplify-start-span
branch
2 times, most recently
from
October 23, 2024 23:30
b7853fe to
3b111cd
Compare
7 tasks
mabdinur
force-pushed
the
munir/simplify-start-span
branch
from
November 12, 2024 02:39
ba968da to
1e7ebde
Compare
mhlidd
reviewed
Nov 13, 2024
mabdinur
force-pushed
the
munir/simplify-start-span
branch
from
November 13, 2024 19:13
8fc8570 to
03b26fc
Compare
mabdinur
force-pushed
the
munir/simplify-start-span
branch
from
November 13, 2024 19:47
03b26fc to
7a8b07e
Compare
mabdinur
marked this pull request as ready for review
November 13, 2024 21:12
mabdinur
requested review from
christophe-papazian,
dmehala,
gnufede,
jandro996 and
smola
and removed request for
a team
November 13, 2024 21:12
bwoebi
reviewed
Nov 13, 2024
bwoebi
reviewed
Nov 13, 2024
cbeauchesne
reviewed
Nov 14, 2024
Collaborator
|
From framework usage, AGTM. But to do a proper review, could you ask to someone familiar with the tested feature ? |
khanayan123
reviewed
Nov 14, 2024
khanayan123
reviewed
Nov 14, 2024
khanayan123
approved these changes
Nov 14, 2024
khanayan123
left a comment
Contributor
There was a problem hiding this comment.
Outside of a minor nit. LGTM
Co-authored-by: Bob Weinand <[email protected]>
mabdinur
commented
Nov 14, 2024
ZStriker19
approved these changes
Nov 14, 2024
ZStriker19
left a comment
Contributor
There was a problem hiding this comment.
From a Python tracer and system-tests perspective looks great! Awesome work!
mtoffl01
reviewed
Nov 14, 2024
mtoffl01
approved these changes
Nov 14, 2024
mtoffl01
left a comment
Contributor
There was a problem hiding this comment.
Fine from my side, although have a question about new spanContexts field on apmClientServer.
cbeauchesne
approved these changes
Nov 15, 2024
cbeauchesne
left a comment
Collaborator
There was a problem hiding this comment.
Framework usage: all good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tracer.start_span(in most languages).Changes
extract_headerendpoint to all parametric apps defined in the the system-tests repo (so not c++)parametric_endpoint_parityfeature.add_linkendpoint. Most tracers do not support creating spans with linksextract_headerAPI (instead of using start_span + http_headers argument)Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present