Skip to content

parametric(otel): enable ruby span events tests#2735

Merged
mabdinur merged 8 commits into
mainfrom
munir/enable-ruby-span-events-system-tests
Jul 26, 2024
Merged

parametric(otel): enable ruby span events tests#2735
mabdinur merged 8 commits into
mainfrom
munir/enable-ruby-span-events-system-tests

Conversation

@mabdinur

@mabdinur mabdinur commented Jul 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

Enables span event tests for ruby

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur
mabdinur force-pushed the munir/enable-ruby-span-events-system-tests branch 2 times, most recently from c635d2a to 7fdd175 Compare July 12, 2024 03:49
mabdinur
mabdinur commented Jul 12, 2024
View reviewed changes
Comment thread tests/parametric/test_otel_span_methods.py Outdated
@mabdinur
mabdinur force-pushed the munir/enable-ruby-span-events-system-tests branch 2 times, most recently from 8dfba1a to 2250d65 Compare July 12, 2024 20:16
@mabdinur
mabdinur force-pushed the munir/enable-ruby-span-events-system-tests branch from 2250d65 to f10ac91 Compare July 12, 2024 20:25
@mabdinur mabdinur mentioned this pull request Jul 16, 2024
Merged
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Library Vulnerabilities

Critical badge  High badge  Medium badge  Low badge

@mabdinur
mabdinur marked this pull request as ready for review July 18, 2024 17:59
@mabdinur
mabdinur requested review from a team and Kyle-Verhoog as code owners July 18, 2024 17:59
@mabdinur
mabdinur requested a review from mcculls July 18, 2024 17:59
robertomonteromiguel
robertomonteromiguel previously requested changes Jul 19, 2024
View reviewed changes

@robertomonteromiguel robertomonteromiguel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failure on Java Parametric, just in the file "test_otel_span_methods.py".
FAILED tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_span_started_with_link_from_w3c_headers[library_env0]
I guess the error it's not related with your changes, but can you confirm this before merge the PR?

@zacharycmontoya

zacharycmontoya commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

There is a failure on Java Parametric, just in the file "test_otel_span_methods.py". FAILED tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_span_started_with_link_from_w3c_headers[library_env0] I guess the error it's not related with your changes, but can you confirm this before merge the PR?

I looked into this and it looks like a transient issue with the gRPC connection to the parametric test app:

debug_error_string = "UNKNOWN:Error received from peer  {created_time:"2024-07-18T18:12:13.16942889+00:00", grpc_status:14, grpc_message:"failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:51003: recvmsg:Connection reset by peer"}"

@mabdinur
mabdinur dismissed robertomonteromiguel’s stale review July 22, 2024 15:27

Java test failures are unrelated to this change

@mabdinur mabdinur changed the title parametric(otel); enable ruby span events tests parametric(otel): enable ruby span events tests Jul 26, 2024
@mabdinur
mabdinur merged commit f827a06 into main Jul 26, 2024
@mabdinur
mabdinur deleted the munir/enable-ruby-span-events-system-tests branch July 26, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes
@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes
@Kyle-Verhoog Kyle-Verhoog Awaiting requested review from Kyle-Verhoog
@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-sdk-capabilities
@robertomonteromiguel robertomonteromiguel Awaiting requested review from robertomonteromiguel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mabdinur @zacharycmontoya @cbeauchesne @robertomonteromiguel