Fixes decision maker tag values for remote user rules and dynamic rules#2394
Merged
yuanyuanzhao3 merged 4 commits intoApr 29, 2024
Merged
Conversation
yuanyuanzhao3
force-pushed
the
yuanyuan.zhao/remote-sampling-rules-dm-collision-fix
branch
2 times, most recently
from
April 25, 2024 17:00
d73dafa to
92ee806
Compare
6 tasks
Collaborator
|
There is a failure on parametric and go related with change. |
robertomonteromiguel
marked this pull request as draft
April 26, 2024 06:25
…mic rules. This is to avoid a conflict with the duplicate value `-10` used by data jobs.
yuanyuanzhao3
force-pushed
the
yuanyuan.zhao/remote-sampling-rules-dm-collision-fix
branch
from
April 26, 2024 13:46
92ee806 to
2fc42bd
Compare
yuanyuanzhao3
marked this pull request as ready for review
April 26, 2024 13:48
yuanyuanzhao3
changed the title
yuanyuanzhao3
changed the title
cbeauchesne
previously requested changes
Apr 29, 2024
cbeauchesne
left a comment
cbeauchesne
left a comment
Collaborator
There was a problem hiding this comment.
CI fails on golang? maybe you're waiting for a PR to be merged on dd-trace-go ?
Contributor
Author
Yes, there is a corresponding dd-trace-go change. But that can't be made easily for the chicken-n-egg problem (see this discussion. |
darccio
approved these changes
Apr 29, 2024
Contributor
Author
Pending dd-trace-go change was merged. All tests passed now. |
yuanyuanzhao3
dismissed
cbeauchesne’s stale review
April 29, 2024 13:41
Depended PR on dd-trace-go merged. All tests passed now.
cbeauchesne
approved these changes
Apr 29, 2024
yuanyuanzhao3
deleted the
yuanyuan.zhao/remote-sampling-rules-dm-collision-fix
branch
April 29, 2024 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid a conflict with the duplicate value
-10used by data jobs.The Go tracer change is also being made and will be released in
1.63.1.Motivation
Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presents[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present