Skip to content

Remove stale test_app_dependencies_loaded_not_sent#2275

Merged
marcotc merged 2 commits into
mainfrom
marcotc/del-test_app_dependencies_loaded_not_sent
Mar 28, 2024
Merged

Remove stale test_app_dependencies_loaded_not_sent#2275
marcotc merged 2 commits into
mainfrom
marcotc/del-test_app_dependencies_loaded_not_sent

Conversation

@marcotc

@marcotc marcotc commented Mar 27, 2024

Copy link
Copy Markdown
Member

The test test_app_dependencies_loaded_not_sent is not relevant anymore for telemetry. No more changes are required to the backend when sending app-dependencies-loaded today.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

The test `test_app_dependencies_loaded_not_sent` is not relevant anymore for telemetry.
No more changes are required to the backend when sending `app-dependencies-loaded ` today.
@marcotc
marcotc marked this pull request as ready for review March 27, 2024 23:24
@marcotc
marcotc requested a review from a team as a code owner March 27, 2024 23:24
@marcotc

marcotc commented Mar 28, 2024

Copy link
Copy Markdown
Member Author

Test failures are caused by unrelated tests, related to sampling.

@marcotc
marcotc merged commit cb6bb9b into main Mar 28, 2024
@marcotc
marcotc deleted the marcotc/del-test_app_dependencies_loaded_not_sent branch March 28, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants