Skip to content

Upgrade Ruby to telemetry v2#2266

Merged
marcotc merged 1 commit into
mainfrom
marcotc/ruby-tel-v2
Mar 27, 2024
Merged

Upgrade Ruby to telemetry v2#2266
marcotc merged 1 commit into
mainfrom
marcotc/ruby-tel-v2

Conversation

@marcotc

@marcotc marcotc commented Mar 26, 2024

Copy link
Copy Markdown
Member

Motivation

With the implementation of Telemetry V2 (DataDog/dd-trace-rb#3551), this PR updates system tests to work with the currently released ddtrace and to unlock testing when Telemetry V2 is released.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@marcotc
marcotc requested a review from a team as a code owner March 26, 2024 21:39
@marcotc
marcotc merged commit 30bbc0f into main Mar 27, 2024
@marcotc
marcotc deleted the marcotc/ruby-tel-v2 branch March 27, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants