Skip to content

Parametric: Add client: golang version: dev#1948

Merged
robertomonteromiguel merged 5 commits into
mainfrom
robertomonteromiguel/parametric_use_load_binary_golang
Dec 22, 2023
Merged

Parametric: Add client: golang version: dev#1948
robertomonteromiguel merged 5 commits into
mainfrom
robertomonteromiguel/parametric_use_load_binary_golang

Conversation

@robertomonteromiguel

@robertomonteromiguel robertomonteromiguel commented Dec 20, 2023

Copy link
Copy Markdown
Collaborator

Motivation

Currently Parametric only executes tests using latest tracer release. We add support to run snapshot version of the golang tracer (dev).

The idea behind this is to use the same approach to install dd-trace-go as is used by system-tests (maintainability reasons).

We are using the previously existing script to install the tracer: utils/build/docker/golang/install_ddtrace.sh

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@robertomonteromiguel
robertomonteromiguel merged commit 0b8cc48 into main Dec 22, 2023
@robertomonteromiguel
robertomonteromiguel deleted the robertomonteromiguel/parametric_use_load_binary_golang branch December 22, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants