Skip to content

Add trace sampling rules tests#1816

Merged
ygree merged 18 commits into
mainfrom
ygree/trace-sampling-rules-spec
Dec 1, 2023
Merged

Add trace sampling rules tests#1816
ygree merged 18 commits into
mainfrom
ygree/trace-sampling-rules-spec

Conversation

@ygree

@ygree ygree commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds trace sampling rules tests.

Motivation

RFC: Extended Ingestion Sampling API - Phase 1
Ingestion Controls with OpenTelemetry / DD_TRACE_SAMPLING_RULES part

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@ygree ygree self-assigned this Nov 9, 2023
@ygree
ygree force-pushed the ygree/trace-sampling-rules-spec branch from fc301e5 to 402be1a Compare November 9, 2023 19:21
@ygree
ygree force-pushed the ygree/trace-sampling-rules-spec branch from 402be1a to 79b373c Compare November 9, 2023 19:24
@ygree ygree mentioned this pull request Nov 10, 2023
Merged
@ygree
ygree force-pushed the ygree/trace-sampling-rules-spec branch from d11fab2 to ffbbb94 Compare November 10, 2023 05:38
@ygree ygree changed the title Add trace sampling rule tests Add trace sampling rules tests Nov 10, 2023
@ygree
ygree force-pushed the ygree/trace-sampling-rules-spec branch from a77bce2 to de2a490 Compare November 11, 2023 08:08
@ygree
ygree marked this pull request as ready for review November 16, 2023 04:58
@ygree
ygree requested a review from a team November 16, 2023 04:58
@ygree
ygree requested review from a team as code owners November 16, 2023 04:58
cbeauchesne
cbeauchesne previously requested changes Nov 16, 2023
View reviewed changes
Comment thread tests/parametric/test_trace_sampling.py
@ygree
ygree force-pushed the ygree/trace-sampling-rules-spec branch from 0a17d53 to 73d2a31 Compare November 17, 2023 01:01
@ygree
ygree requested a review from cbeauchesne November 17, 2023 19:20
@ygree ygree mentioned this pull request Nov 21, 2023
Closed
5 tasks
@ygree
ygree force-pushed the ygree/trace-sampling-rules-spec branch from 8a5d97c to 94e1198 Compare November 22, 2023 00:07
@brettlangdon
brettlangdon dismissed cbeauchesne’s stale review November 28, 2023 16:59

changes have been addressed

cbeauchesne
cbeauchesne requested changes Nov 30, 2023
View reviewed changes

@cbeauchesne cbeauchesne left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a modification in manifest/cpp.yml and it should be ok

@ygree
ygree force-pushed the ygree/trace-sampling-rules-spec branch from 79c137b to e753230 Compare November 30, 2023 19:16
@ygree
ygree force-pushed the ygree/trace-sampling-rules-spec branch from e753230 to d0d6d03 Compare November 30, 2023 19:19
@ygree
ygree requested a review from cbeauchesne November 30, 2023 23:42
@ygree
ygree merged commit ae904e2 into main Dec 1, 2023
@ygree
ygree deleted the ygree/trace-sampling-rules-spec branch December 1, 2023 21:57
@ygree ygree mentioned this pull request Dec 5, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes
@cbeauchesne cbeauchesne cbeauchesne approved these changes
@robertomonteromiguel robertomonteromiguel robertomonteromiguel approved these changes
@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87 P403n1x87 is a code owner automatically assigned from DataDog/apm-python
@Yun-Kim Yun-Kim Awaiting requested review from Yun-Kim Yun-Kim is a code owner automatically assigned from DataDog/apm-python
@anderruiz anderruiz Awaiting requested review from anderruiz anderruiz is a code owner automatically assigned from DataDog/asm-java
@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java
@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees

@ygree ygree

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ygree @ValentinZakharov @cbeauchesne @robertomonteromiguel