Skip to content

Run ruby trace header precedence test#1454

Closed
TonyCTHsu wants to merge 1 commit into
tonycthsu/parametric-ruby-on-m1from
tonycthsu/fix-ruby-header-precedence
Closed

Run ruby trace header precedence test#1454
TonyCTHsu wants to merge 1 commit into
tonycthsu/parametric-ruby-on-m1from
tonycthsu/fix-ruby-header-precedence

Conversation

@TonyCTHsu

@TonyCTHsu TonyCTHsu commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

Description

With this change in tracer, we can enable parametric tests for trace header precedence.

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

@cbeauchesne

Copy link
Copy Markdown
Collaborator

Hi @TonyCTHsu , do you still plan to work on this?

@TonyCTHsu TonyCTHsu closed this Sep 6, 2024
@cbeauchesne
cbeauchesne deleted the tonycthsu/fix-ruby-header-precedence branch September 6, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants