Fix remote configuration assertion for is_agent and config_states#1074
Merged
Conversation
GustavoCaso
commented
Apr 14, 2023
|
|
||
| # verify that the tracer is properly storing and reporting on its config state | ||
| expected_config_states = client_state.get("config_states") | ||
| expected_config_states = expected.get("config_states") |
Contributor
Author
There was a problem hiding this comment.
We were not using the expected here so we always compared the same client state
GustavoCaso
commented
Apr 14, 2023
| config_states = client_state.get("config_states") | ||
| if expected_config_states is None and config_states is not None: | ||
|
|
||
| if expected_config_states is None and (config_states is not None and len(config_states) > 0): |
Contributor
Author
There was a problem hiding this comment.
Base on the RFC config_states can be null or empty list
GustavoCaso
commented
Apr 14, 2023
| client_tracer = client["client_tracer"] | ||
|
|
||
| assert "is_agent" not in client, "'client.is_agent' MUST either NOT be set or set to false" | ||
| assert "is_agent" not in client or client['is_agent'] == False, "'client.is_agent' MUST either NOT be set or set to false" |
Contributor
Author
There was a problem hiding this comment.
is_agent could be false
GustavoCaso
force-pushed
the
fix-remote-assertions
branch
from
April 14, 2023 11:02
cb7c4ee to
7503b75
Compare
GustavoCaso
marked this pull request as ready for review
April 14, 2023 11:03
GustavoCaso
force-pushed
the
fix-remote-assertions
branch
from
April 14, 2023 14:08
7503b75 to
634edfa
Compare
ameske
approved these changes
Apr 14, 2023
marcotc
approved these changes
Apr 14, 2023
cbeauchesne
reviewed
Apr 18, 2023
cbeauchesne
left a comment
cbeauchesne
left a comment
Collaborator
There was a problem hiding this comment.
The CI is massively failing, I need to take some time to understand what's happening, I will do it asap
Collaborator
|
Ok, once the test is fixed, turns out java and go seems no to be compliant. Just wait for confirmation before merging. |
Collaborator
smola
approved these changes
Apr 25, 2023
smola
left a comment
smola
left a comment
Member
There was a problem hiding this comment.
Fix for Java coming up on: DataDog/dd-trace-java#5114
cbeauchesne
force-pushed
the
fix-remote-assertions
branch
from
April 27, 2023 13:45
992ffde to
f2af2b0
Compare
cbeauchesne
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix remote configuration assertion for
is_agentandconfig_statesWorkflow
Once your PR is reviewed, you can merge it ! ❤️