Add a check on status code reported by appsec#1
Merged
Conversation
nizox
pushed a commit
that referenced
this pull request
Dec 14, 2021
handle protobuf messages and remove unnecessary decompression
2 tasks
5 tasks
bm1549
added a commit
that referenced
this pull request
Jul 15, 2026
Resolve conflict in utils/docker_fixtures/_test_agent.py and apply Charles's review feedback in the same pass: - start_agent is now a @contextmanager (keeps main's extra_hosts/HOST_GATEWAY), so container + log file are released cleanly on any setup/teardown error (review #1). The fresh path uses it via `with`. - WorkerAgentPool is a context manager holding an ExitStack; pooled agents are kept open across tests and torn down at pool exit. Drops AgentLease/stop and the public shutdown() (review #3). conftest uses `with ... as pool`. - The pool creator in _docker_fixtures.py is a @contextmanager (agent + network). - poolable branch passes an explicit agent_env={} rather than the always-falsy variable (review #2). Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.